Also create pid file in non-daemon mode #4951

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_09_pidfile changing 4 files +9 −4

laanwj commented at 9:05 AM on September 20, 2014: member
Always make a pid file, not only when -daemon specified.

This is useful for troubleshooting, for attaching debuggers and loggers and such.
- Write the pid file only after the datadir lock was acquired
- Don't create or remove a pid file on WIN32, and also don't show the option

Also create pid file in non-daemon mode

Always make a pid file, not only when `-daemon` specified.

This is useful for troubleshooting, for attaching debuggers and loggers
and such.

- Write the pid file only after the datadir lock was acquired
- Don't create or remove a pid file on WIN32, and also don't show the option

d6712db354

BitcoinPullTester commented at 9:20 AM on September 20, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4951_d6712db35419e36b2c89191eb730a86d95abf4b0/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 4:55 PM on September 20, 2014: none

ut ACK
sipa commented at 5:12 PM on September 20, 2014: member

ut ACK. Mostly harmless.
laanwj merged this on Sep 22, 2014
laanwj closed this on Sep 22, 2014
laanwj referenced this in commit aa340a8f07 on Sep 22, 2014
DrahtBot locked this on Sep 8, 2021

Contributors