Fix build on Debian Wheezy #4961

pull Spacefish wants to merge 3 commits into bitcoin:master from Spacefish:master changing 8 files +171 −170

Spacefish commented at 7:40 PM on September 22, 2014: none

I was unable to build the bitcoind on debian wheezy, it turned out to be a ambiguous definition of int64_t and uint64_t as described in issue #3483 . I therefore prefixed every usage of this type to tell the compiler to use the stdlib type and not the boost type. I am now able to build / run the client.
prefixed int64_t and uint64_t with :: to use libc implementation. Otherwise the symbol might be ambiguous with boost:int64_t. Fixes #3483 1e861060c0
sipa commented at 7:41 PM on September 22, 2014: member

There should be much cleaner solutions to this IMHO, such as not 'using namespace boost'.
theuni commented at 7:42 PM on September 22, 2014: member

I'd much rather drop the boost namespace here.
Spacefish commented at 7:43 PM on September 22, 2014: none

Yes, this solution is not the best. However when "using boost" is not that nice either.. However if we remove using boost, we have to prefix everything else that is used out of boost. IMHO Boost shouldn´t redefine int64_t and uint64_t, there are some macros inside boost which detect glibc and so on via defines, but they don´t seem to work... at least not in boost 1.49 on debian wheezy for me.
Merge https://github.com/Spacefish/bitcoin 211d358c57
theuni commented at 7:45 PM on September 22, 2014: member

Heh, agreed with @sipa. @Spacefish that's the right thing to do. If something's using boost, it should be made clear.
corrected a merge error 0bc69687b2
BitcoinPullTester commented at 7:54 PM on September 22, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4961_0bc69687b2a71dfdecd6bc7fa6abc72567d23d38/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 8:14 PM on September 22, 2014: member

I agree with @sipa and @theuni on not using namespace boost (and prefixing the boost types/methods) being preferable to prefixing all uses of [u]int64.

But foremost... I wonder why we don't have this issue in the environments that we use? What is different here?
Spacefish commented at 10:45 PM on September 22, 2014: none

i don´t really know.. i guess there are some libs messed up on that machine, but as there is a bugreport with the same problem, i just fixed it in the code. Now it works for me. Wanted to share the patch, but i don´t have the time to remove all "using namespace boost;" and prefixing everything.. sry.
laanwj commented at 7:05 AM on September 23, 2014: member

Ok, closing this in that case.
laanwj closed this on Sep 23, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#3483 boost, reference to ‘int64_t’ is ambiguous