Avoiding referencing elements of an empty vector
Fixing runtime boundary violation #4967
pull ENikS wants to merge 1 commits into bitcoin:master from ENikS:hash_test_fix changing 1 files +36 −33-
ENikS commented at 3:57 PM on September 23, 2014: contributor
-
Avoiding referencing elements of an empty vector 459a2d25e0
-
BitcoinPullTester commented at 4:11 PM on September 23, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4967_459a2d25e0c91d1650974900a902285bedb85f39/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 5:11 PM on September 23, 2014: member
ACK
-
theuni commented at 6:06 PM on September 23, 2014: member
Does this pass tests? Meaning: does the hash of an empty input match what is expected? If so, ACK.
-
laanwj commented at 6:12 PM on September 23, 2014: member
It passes the pulltester and Travis, both do all kinds of hash tests (including empty hashes), as well as the bloom tests that use this hash function...
-
-
sipa commented at 6:27 PM on September 23, 2014: member
utACK
- laanwj merged this on Sep 25, 2014
- laanwj closed this on Sep 25, 2014
- laanwj referenced this in commit 8152f4efd8 on Sep 25, 2014
- ENikS deleted the branch on Sep 25, 2014
- MarcoFalke locked this on Sep 8, 2021
Contributors
Linked (view graph)