Normally pc holds iterator to begin(). After line 547 is executed and few elements are erased from the head this variable needs to be re-initialized with iterator to a new head of the list.
Fixed list's begin iterator after elements erase #4969
pull ENikS wants to merge 1 commits into bitcoin:master from ENikS:script_p2sh_tests_fix changing 1 files +1 −1-
ENikS commented at 8:37 PM on September 23, 2014: contributor
-
theuni commented at 8:48 PM on September 23, 2014: member
I've hit this one as well while adding the libstdc++ debug. No need to reset to the beginning, just take the updated iter:
pc = erase(pc, pc + b.size()); -
-
Reinitializing list's begin iterator after few elements were erased from the head cda45b5131
-
BitcoinPullTester commented at 10:48 PM on September 23, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4969_cda45b5131c3546b870d8cea3191fb29df182b27/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
theuni commented at 11:01 PM on September 23, 2014: member
Thanks. ACK.
- laanwj merged this on Sep 25, 2014
- laanwj closed this on Sep 25, 2014
- laanwj referenced this in commit 4b2b78b9f2 on Sep 25, 2014
- ENikS deleted the branch on Sep 25, 2014
- MarcoFalke locked this on Sep 8, 2021
Contributors
Linked (view graph)