Apply clang-format on crypto/* and compat/* #4977

pull sipa wants to merge 1 commits into bitcoin:master from sipa:clang changing 11 files +589 −458

sipa commented at 6:31 AM on September 25, 2014: member

No description provided.
Apply clang-format on crypto/* and compat/* cf42c36e99
BitcoinPullTester commented at 6:46 AM on September 25, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4977_cf42c36e9963f9cf13704d8d74a9546f0db33d40/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 7:50 AM on September 25, 2014: member

It may be just me being paranoid, but we should verify that the compiled code stays exactly the same here. The crypto code looks fragile, with all those macros and carefully crafted tables of operations.
Diapolo commented at 11:45 AM on September 25, 2014: none

@laanwj Agreed, I guess it's easy for you to just diff the resulting binaries. And if nothing changes, this is a big ACK from me.
Diapolo commented at 12:28 PM on September 25, 2014: none

Any reason to not also now cover script, secp256k1, test and univalue :)?
theuni commented at 9:25 PM on September 25, 2014: member

Confirmed that the compiled objects remain the same before/after this commit, with the exception of version.o which is to be expected.
laanwj commented at 6:54 AM on September 26, 2014: member

@theuni Thanks for verifying ACK
Diapolo commented at 7:17 AM on September 26, 2014: none

ACK
theuni commented at 5:20 PM on September 26, 2014: member

That was an ACK from me too, btw.

sipa commented at 5:25 PM on September 26, 2014: member

Compared hexdumps of the stripped bitcoind binaries before/after this patch:

$ diff bitcoind-clang.hd bitcoind-noclang.hd 
44,45c44,45
< 000002b0  14 00 00 00 03 00 00 00  47 4e 55 00 a6 f2 5f 89  |........GNU..._.|
< 000002c0  ef 8e 7d 91 50 f6 08 c7  13 af a8 b5 e1 b8 38 27  |..}.P.........8'|
---
> 000002b0  14 00 00 00 03 00 00 00  47 4e 55 00 e8 67 cf 04  |........GNU..g..|
> 000002c0  ab c5 22 90 65 eb eb a8  69 04 80 53 96 ce 20 e5  |..".e...i..S.. .|
214205,214206c214205,214206
< 00345cc0  2d 63 66 34 32 63 33 36  00 32 30 31 34 2d 30 39  |-cf42c36.2014-09|
< 00345cd0  2d 32 35 20 30 38 3a 32  33 3a 33 32 20 2b 30 32  |-25 08:23:32 +02|
---
> 00345cc0  2d 65 61 36 39 35 39 32  00 32 30 31 34 2d 30 39  |-ea69592.2014-09|
> 00345cd0  2d 32 34 20 32 31 3a 31  35 3a 35 38 20 2b 30 32  |-24 21:15:58 +02|

which looks like the git version, and some header bytes.

sipa merged this on Sep 26, 2014
sipa closed this on Sep 26, 2014
sipa referenced this in commit c2db599c1f on Sep 26, 2014
Diapolo commented at 11:51 AM on September 27, 2014: none

See #4990 which ist the final polish IMHO to these 2 folders for now.
MarcoFalke locked this on Sep 8, 2021

Contributors