Removed \n inside method declaration #4984

Although technically it is not an error to declare method like this but it is rather unconventional. It would also be useful to be able to use grep/search when looking for this method

Array read_json(const std::string& jsondata)

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4984_c3f058307983f25fbd58c5dd4eee2b100c5db3ef/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

ACK (though this will be done automatically when we clang-format it).

I'll channel Wladimir: NACK -- no whitespace changes, all the whitespace will be cleaned up as we move to clang-format.

This one is rather different from the rest of the code. It is used in consuming of these generated test headers and important for someone who port it to new platform. It took me some digging to find the method because it is not easily recognizable in search results. So to make life a bit easier for these who comes next... But I guess it can wait for clang-format integration. After this PR is indexed by Google it should not matter when it is fixed. People will be able to find this method even in present form.

@sipa As I suggested, just do the clang format for all sources in dirs below main :). Excluding perhaps only that json stuff because of the license.

Agree with @gavinandresen. Let's just put the tests through the clang-format-wrangler some time, and this will be fixed.