Make the version number the protocol version and not the client version #5

1. 
   cdecker commented at 8:06 pm on December 19, 2010: contributor

   As there is a String field (SubVersionNum) I think it would be better not to increment the protocol version along with the client version number. It makes creating alternative clients easier.
2. 
   tcatm commented at 1:25 am on February 6, 2011: none

   Anyone thoughts on this? It’s now one month old. I’ll close it in a few days if no one comments on this.
3. 
   cdecker commented at 3:03 pm on February 6, 2011: contributor

   Well we do have 4 upvotes, so it is something that has some interest. Generally we should distinguish better between the Protocol and Satoshis client.
4. 
   tcatm commented at 6:16 pm on February 6, 2011: none

   Can you make a patch?
5. 
   cdecker commented at 6:19 pm on February 6, 2011: contributor

   It’s not really something you can “patch”, it’s all about not increasing the version number in the version message if the update does not break backward compatibility. instead of using the version number use the version string to identify the client and client version.
6. 
   tcatm commented at 6:24 pm on February 6, 2011: none

   Well, a patch would at least add a constant PROTOCOL_VERSION = xyz, wouldn’t it?
7. 
   cdecker commented at 6:46 pm on February 6, 2011: contributor

   I’ll look into it ^^ How should I submit it?
8. 
   tcatm commented at 6:53 pm on February 6, 2011: none

   pull request :)
9. 
   cdecker commented at 6:21 pm on February 10, 2011: contributor

   Ok, submitted the pull request. Please review :D It’s not much but this is more of a design change than a code change ^^
10. 
    jgarzik commented at 7:02 am on February 13, 2011: contributor

    This seems to be opposite of satoshi’s intent.
11. 
    cdecker commented at 9:22 am on February 13, 2011: contributor

    Comments moved to pull request.
12. laanwj referenced this in commit 679592720a on Sep 18, 2011
13. sipa referenced this in commit 21b74c7e5f on Jun 2, 2013
14. nelisky referenced this in commit a9c69f2a26 on Aug 8, 2013
15. kac- referenced this in commit e3944f5779 on Mar 25, 2014
16. justmoon referenced this in commit 2e9eab1867 on Apr 7, 2014
17. kac- referenced this in commit 0dc2b71ed0 on Apr 22, 2014
18. ahmedbodi referenced this in commit 71bdd18af3 on Aug 6, 2014
19. kac- referenced this in commit 35f0a4e2e9 on Oct 8, 2014
20. rdponticelli referenced this in commit 50713b0e64 on Nov 26, 2014
21. laanwj referenced this in commit e688d9edb0 on Mar 26, 2015
22. dexX7 referenced this in commit abac370c4b on May 20, 2015
23. destenson referenced this in commit 280d6c0583 on Jun 26, 2016
24. MarcoFalke referenced this in commit e504cff291 on Dec 9, 2016
25. MarcoFalke referenced this in commit 8501bedd75 on Dec 9, 2016
26. ptschip referenced this in commit f5b8a11780 on May 1, 2017
27. kleetus referenced this in commit 1ab2dda4b2 on Jun 13, 2017
28. AkioNak referenced this in commit a593ffa0c9 on Jul 24, 2017
29. laanwj referenced this in commit b13a68e129 on Aug 2, 2017
30. laanwj referenced this in commit 659c096134 on Aug 2, 2017
31. fametrano referenced this in commit ecbd242045 on Aug 4, 2017
32. JeremyRubin referenced this in commit 7f378349b2 on Aug 9, 2017
33. destenson referenced this in commit 99cfe5237f on Aug 31, 2017
34. MarcoFalke referenced this in commit a243b3d2e6 on Sep 29, 2017
35. achow101 referenced this in commit 26bef49795 on Nov 17, 2017
36. MarcoFalke referenced this in commit 4b11505e71 on Jan 15, 2018
37. MarcoFalke referenced this in commit 03e5f0a312 on Feb 7, 2018
38. MarcoFalke referenced this in commit a570098021 on Feb 10, 2018
39. hkjn referenced this in commit 62d55d023a on Feb 12, 2018
40. esotericnonsense referenced this in commit 1e9e390eda on Feb 19, 2018
41. Willtech referenced this in commit d5f6f4cc0d on Feb 23, 2018
42. HashUnlimited referenced this in commit fb8585691c on Mar 9, 2018
43. effectsToCause referenced this in commit df7c60fa84 on Jun 22, 2018
44. MarcoFalke referenced this in commit 4d550ffab6 on Jul 30, 2018
45. hashtobewild referenced this in commit b0311244c3 on Aug 26, 2018
46. dooglus referenced this in commit c2f5dec2ce on Oct 20, 2018
47. lionello referenced this in commit 99f0128041 on Nov 7, 2018
48. cryptapus referenced this in commit b74dfba83e on Jan 12, 2019
49. MarcoFalke referenced this in commit 6899ef3f0e on Jun 11, 2019
50. MarcoFalke referenced this in commit 98958c81f5 on Jun 17, 2019
51. sipsorcery referenced this in commit e9c85bb139 on Nov 7, 2019
52. laanwj referenced this in commit 89e93135ae on Nov 10, 2019
53. MarcoFalke referenced this in commit cf43f3f0a8 on Dec 5, 2019
54. MarcoFalke referenced this in commit bb03765e2d on Dec 8, 2019
55. Warchant referenced this in commit 7958da26e8 on Dec 31, 2019
56. laanwj referenced this in commit 66480821b3 on Feb 10, 2020
57. Bushstar referenced this in commit 707f3ec860 on Apr 8, 2020
58. laanwj referenced this in commit 31bdd86631 on Jul 15, 2020
59. KolbyML referenced this in commit 99aafab856 on Aug 1, 2020
60. laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
61. jonasschnelli referenced this in commit c33662a0ea on Dec 2, 2020
62. KolbyML referenced this in commit 3d9f0283ff on Dec 5, 2020
63. laanwj referenced this in commit e520e091db on Jan 6, 2021
64. rajarshimaitra referenced this in commit 3f5d261950 on Mar 23, 2021
65. rajarshimaitra referenced this in commit db9c5dfbc1 on Mar 23, 2021
66. MarcoFalke referenced this in commit 590e49ccf2 on Apr 4, 2021
67. MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
68. fanquake referenced this in commit fa00bb2c5c on Apr 29, 2021
69. MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
70. laanwj referenced this in commit ee9befe8b4 on May 12, 2021
71. MarcoFalke referenced this in commit c857148636 on May 15, 2021
72. satindergrewal referenced this in commit 23c8b025b7 on Jun 22, 2021
73. satindergrewal referenced this in commit 9e9ab1cb30 on Jun 22, 2021
74. satindergrewal referenced this in commit c7c6c0c551 on Jun 22, 2021
75. rajarshimaitra referenced this in commit 37e068de4a on Aug 5, 2021
76. mjdietzx referenced this in commit a01b804085 on Sep 2, 2021
77. mjdietzx referenced this in commit 84c88ec984 on Sep 2, 2021
78. rrybarczyk referenced this in commit 4f72c30655 on Sep 21, 2021
79. mjdietzx referenced this in commit 85a69f40dd on Sep 26, 2021
80. mjdietzx referenced this in commit e6c88a358a on Oct 28, 2021
81. mjdietzx referenced this in commit a9a9d3f047 on Oct 29, 2021
82. mjdietzx referenced this in commit 12509a080e on Nov 21, 2021
83. mjdietzx referenced this in commit 3fc1f8b612 on Nov 21, 2021
84. mjdietzx referenced this in commit 54782ae605 on Nov 28, 2021
85. mjdietzx referenced this in commit 02ea5b482f on Nov 28, 2021
86. mjdietzx referenced this in commit 88a9a46056 on Nov 28, 2021
87. mjdietzx referenced this in commit e1d9773000 on Dec 1, 2021
88. mjdietzx referenced this in commit 64c20402b2 on Dec 1, 2021
89. Idan-Neeman referenced this in commit 9a7b9f03db on Dec 16, 2021
90. DrahtBot locked this on Dec 16, 2021

Contributors
cdecker tcatm jgarzik

Labels
Feature