Make the version number the protocol version and not the client version #5

issue cdecker opened this issue on December 19, 2010
  1. cdecker commented at 8:06 PM on December 19, 2010: contributor

    As there is a String field (SubVersionNum) I think it would be better not to increment the protocol version along with the client version number. It makes creating alternative clients easier.

  2. tcatm commented at 1:25 AM on February 6, 2011: none

    Anyone thoughts on this? It's now one month old. I'll close it in a few days if no one comments on this.

  3. cdecker commented at 3:03 PM on February 6, 2011: contributor

    Well we do have 4 upvotes, so it is something that has some interest. Generally we should distinguish better between the Protocol and Satoshis client.

  4. tcatm commented at 6:16 PM on February 6, 2011: none

    Can you make a patch?

  5. cdecker commented at 6:19 PM on February 6, 2011: contributor

    It's not really something you can "patch", it's all about not increasing the version number in the version message if the update does not break backward compatibility. instead of using the version number use the version string to identify the client and client version.

  6. tcatm commented at 6:24 PM on February 6, 2011: none

    Well, a patch would at least add a constant PROTOCOL_VERSION = xyz, wouldn't it?

  7. cdecker commented at 6:46 PM on February 6, 2011: contributor

    I'll look into it ^^ How should I submit it?

  8. tcatm commented at 6:53 PM on February 6, 2011: none

    pull request :)

  9. cdecker commented at 6:21 PM on February 10, 2011: contributor

    Ok, submitted the pull request. Please review :D It's not much but this is more of a design change than a code change ^^

  10. jgarzik commented at 7:02 AM on February 13, 2011: contributor

    This seems to be opposite of satoshi's intent.

  11. cdecker commented at 9:22 AM on February 13, 2011: contributor

    Comments moved to pull request.

  12. laanwj referenced this in commit 679592720a on Sep 18, 2011
  13. sipa referenced this in commit 21b74c7e5f on Jun 2, 2013
  14. nelisky referenced this in commit a9c69f2a26 on Aug 8, 2013
  15. kac- referenced this in commit e3944f5779 on Mar 25, 2014
  16. justmoon referenced this in commit 2e9eab1867 on Apr 7, 2014
  17. kac- referenced this in commit 0dc2b71ed0 on Apr 22, 2014
  18. ahmedbodi referenced this in commit 71bdd18af3 on Aug 6, 2014
  19. kac- referenced this in commit 35f0a4e2e9 on Oct 8, 2014
  20. rdponticelli referenced this in commit 50713b0e64 on Nov 26, 2014
  21. laanwj referenced this in commit e688d9edb0 on Mar 26, 2015
  22. dexX7 referenced this in commit abac370c4b on May 20, 2015
  23. destenson referenced this in commit 280d6c0583 on Jun 26, 2016
  24. MarcoFalke referenced this in commit e504cff291 on Dec 9, 2016
  25. MarcoFalke referenced this in commit 8501bedd75 on Dec 9, 2016
  26. ptschip referenced this in commit f5b8a11780 on May 1, 2017
  27. kleetus referenced this in commit 1ab2dda4b2 on Jun 13, 2017
  28. AkioNak referenced this in commit a593ffa0c9 on Jul 24, 2017
  29. laanwj referenced this in commit b13a68e129 on Aug 2, 2017
  30. laanwj referenced this in commit 659c096134 on Aug 2, 2017
  31. fametrano referenced this in commit ecbd242045 on Aug 4, 2017
  32. JeremyRubin referenced this in commit 7f378349b2 on Aug 9, 2017
  33. destenson referenced this in commit 99cfe5237f on Aug 31, 2017
  34. MarcoFalke referenced this in commit a243b3d2e6 on Sep 29, 2017
  35. achow101 referenced this in commit 26bef49795 on Nov 17, 2017
  36. MarcoFalke referenced this in commit 4b11505e71 on Jan 15, 2018
  37. MarcoFalke referenced this in commit 03e5f0a312 on Feb 7, 2018
  38. MarcoFalke referenced this in commit a570098021 on Feb 10, 2018
  39. hkjn referenced this in commit 62d55d023a on Feb 12, 2018
  40. esotericnonsense referenced this in commit 1e9e390eda on Feb 19, 2018
  41. Willtech referenced this in commit d5f6f4cc0d on Feb 23, 2018
  42. HashUnlimited referenced this in commit fb8585691c on Mar 9, 2018
  43. effectsToCause referenced this in commit df7c60fa84 on Jun 22, 2018
  44. MarcoFalke referenced this in commit 4d550ffab6 on Jul 30, 2018
  45. hashtobewild referenced this in commit b0311244c3 on Aug 26, 2018
  46. dooglus referenced this in commit c2f5dec2ce on Oct 20, 2018
  47. lionello referenced this in commit 99f0128041 on Nov 7, 2018
  48. cryptapus referenced this in commit b74dfba83e on Jan 12, 2019
  49. MarcoFalke referenced this in commit 6899ef3f0e on Jun 11, 2019
  50. MarcoFalke referenced this in commit 98958c81f5 on Jun 17, 2019
  51. sipsorcery referenced this in commit e9c85bb139 on Nov 7, 2019
  52. laanwj referenced this in commit 89e93135ae on Nov 10, 2019
  53. MarcoFalke referenced this in commit cf43f3f0a8 on Dec 5, 2019
  54. MarcoFalke referenced this in commit bb03765e2d on Dec 8, 2019
  55. Warchant referenced this in commit 7958da26e8 on Dec 31, 2019
  56. laanwj referenced this in commit 66480821b3 on Feb 10, 2020
  57. Bushstar referenced this in commit 707f3ec860 on Apr 8, 2020
  58. laanwj referenced this in commit 31bdd86631 on Jul 15, 2020
  59. KolbyML referenced this in commit 99aafab856 on Aug 1, 2020
  60. laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
  61. jonasschnelli referenced this in commit c33662a0ea on Dec 2, 2020
  62. KolbyML referenced this in commit 3d9f0283ff on Dec 5, 2020
  63. laanwj referenced this in commit e520e091db on Jan 6, 2021
  64. rajarshimaitra referenced this in commit 3f5d261950 on Mar 23, 2021
  65. rajarshimaitra referenced this in commit db9c5dfbc1 on Mar 23, 2021
  66. MarcoFalke referenced this in commit 590e49ccf2 on Apr 4, 2021
  67. MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
  68. fanquake referenced this in commit fa00bb2c5c on Apr 29, 2021
  69. MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
  70. laanwj referenced this in commit ee9befe8b4 on May 12, 2021
  71. MarcoFalke referenced this in commit c857148636 on May 15, 2021
  72. satindergrewal referenced this in commit 23c8b025b7 on Jun 22, 2021
  73. satindergrewal referenced this in commit 9e9ab1cb30 on Jun 22, 2021
  74. satindergrewal referenced this in commit c7c6c0c551 on Jun 22, 2021
  75. rajarshimaitra referenced this in commit 37e068de4a on Aug 5, 2021
  76. mjdietzx referenced this in commit a01b804085 on Sep 2, 2021
  77. mjdietzx referenced this in commit 84c88ec984 on Sep 2, 2021
  78. rrybarczyk referenced this in commit 4f72c30655 on Sep 21, 2021
  79. mjdietzx referenced this in commit 85a69f40dd on Sep 26, 2021
  80. mjdietzx referenced this in commit e6c88a358a on Oct 28, 2021
  81. mjdietzx referenced this in commit a9a9d3f047 on Oct 29, 2021
  82. mjdietzx referenced this in commit 12509a080e on Nov 21, 2021
  83. mjdietzx referenced this in commit 3fc1f8b612 on Nov 21, 2021
  84. mjdietzx referenced this in commit 54782ae605 on Nov 28, 2021
  85. mjdietzx referenced this in commit 02ea5b482f on Nov 28, 2021
  86. mjdietzx referenced this in commit 88a9a46056 on Nov 28, 2021
  87. mjdietzx referenced this in commit e1d9773000 on Dec 1, 2021
  88. mjdietzx referenced this in commit 64c20402b2 on Dec 1, 2021
  89. Idan-Neeman referenced this in commit 9a7b9f03db on Dec 16, 2021
  90. DrahtBot locked this on Dec 16, 2021
Contributors
cdeckertcatmjgarzik
Labels
Feature
Linked (view graph)
#63 Differentiate Protocol version from client version#156 UPnP segfault#340 bug introduced in 0.3.23, crash when no network interfaces up.#447 RPC 'sendfrom' with invalid address crashes bitcoind#672 bitcoin-qt crashes in db on startup#737 Deadlock during startup (Appears to be AddAddress / DNSSeed related)#982 Startup blocks on mutex at "Loading Addresses"#999 v0.6.0rc5 segfault on initial blockchain download when out of diskspace#1065 addrMan crash on CentOS#1098 segfault in qrcode message dialog#1156 Addrman crash#1182 bitcoin-qt usually SEGVs when exited using unix signals#1294 NULL ptr deref when press Ctrl+C right after starting bitcoind#1472 detachdb - coredump backtrace#1505 Boost exceptions in ReadConfigFile() not caught#2397 ReserveKeyFromKeyPool(): read failed#2416 Bitcoind aborts on startup: ./db/skiplist.h:152 Assertion `n >= 0' failed.#2472 System error: database corrupted: void boost::recursive_mutex::lock(): Assertion `!pthread_mutex_lock(&m)' failed#3997 crash in CMerkleTx::GetDepthInMainChainINTERNAL()#4410 bitcoin-qt core dumping#4499 Watchonly code: cs_main lock not held#4502 GetMyExternalIP hangs shutdown when waiting for response#4523 Stuck in futex(0xb71905fc, FUTEX_WAIT_PRIVATE, 1, NULL#4995 null pointer of pindexPrev crash.#5330 cs_main lock not held when reindexing blocks on disk?#5698 Code vulnerable to segfault after a network fork#5795 Bizarre test_bitcoin crash, but passes in debugger#5910 Gitian 64-bit bitcoin-qt segfaults on Ubuntu 14.04#6332 Segmentation fault on bitcoind or bitcoin-qt startup (64bit Linux)#6411 connection limit calculation for select() is overly ambitious with -txindex#6540 scheduler_tests (currently disabled) occasionally deadlocks#6775 Bitcoind v0.11.0 segfaults on startup trying to read wallet.#8984 GUI hangs during sync#9348 Node crashed with assertion failure in network code#9687 bitcoin-qt crashed in FinalizeNode()#9759 Setting -maxsigcachesize to zero causes segfault#9881 v0.14.0rc2 crash on shutdown#9883 [Qt] Segfault on startup#9997 Running out of disk space during GUI init results in hang and non-drawing windows#10209 Stalled shutdown#10210 Frozen (for 15 minutes) on shutdown [dnsseed thread]#10293 SEGV in segwit fundrawtransaction#10611 Gitian build (current master) crashes on OSX#10861 Segfault on shutdown after pressing 'q' to postpone utxo db upgrade#10958 Update to latest Bitcoin patches for LevelDB#11114 CScript += operator double free if destination and operand are the same.#11355 LevelDB read failure: Corruption: block checksum mismatch#11763 deadlock on shutdown#12038 deadlock on database corruption#12229 Shutdown deadlock in SyncWithValidationInterfaceQueue#12279 shutdown took 8 minutes in v0.15.0.1#12690 LevelDB "corrupted compressed block contents" errors#12915 Segmentation fault in util: ScheduleBatchPriority#12943 Segfault on startup at a04440#13316 make check fails for configure option --with-incompatible-bdb and Berkeley DB 5.3#13806 qa: Fix bench/block_assemble assert failure#14330 [tests] segfault during`DEBUG=1` run of existing_data_no_obfuscate locally#14349 mac: make check failure on macOS 10.14#14359 bitcoin-qt hangs in futex() / __cxa_guard_acquire()#14754 bitcoin-qt hangs on startup on Ubuntu 18.10/Debian Buster#14842 segfault in bench_bitcoin if configured using --with-libs=no#14923 segmentation fault on gui startup#14967 TSAN issue in cuckoocache_erase_parallel_ok test after 14935#15227 bitcoind terminated with uncaught exception if configure --debug-enabled#15300 rpc: segfault if combinepsbt called with empty inputs#15310 gui: crash if encrypt / change passphrase window is open and wallet is unloaded#15379 bitcoind crashes after exception in scheduler thread#15674 Segmentation fault on Ubuntu Linux with trickle#15819 macOS: crash while loading wallet with berkeley-db@4#16133 ThreadSanitizer intermittently reports data race when shutting down node#16143 tests: Mark unit test blockfilter_index_initial_sync as non-deterministic#16157 Line coverage non-determinism in unit test(s) calling SerializeFileDB#16221 tests: Mark test coins_tests/updatecoins_simulation_test as non-deterministic#16225 tests: Make coins_tests/updatecoins_simulation_test deterministic#16307 scheduler: crash after releasing wallet#16815 wallet: CPU use proportional to wallet transaction count when idle#16875 gui: Avoid calling processEvents#16904 Bus error (core dumped) after "Using obfuscation key for" log line#17010 Missing Boost::System on ARM Ubuntu 18.04#17427 qt: Fix missing qRegisterMetaType for size_t#17540 ci build fails in ./qt/test/test_bitcoin-qt on aarch64 native tsan#17572 Listunspent 0 0 doens't see zero conf tx from multisig address#17620 MemorySanitizer complains about unitialized variable in RPC method names#17627 Suppress false positive warning about uninitialized entropy buffers#17674 tests: Add initialization order fiasco detection in Travis#17685 tests: Fix bug in the descriptor parsing fuzzing harness (descriptor_parse)#17729 Fuzzing Bug undefined-behavior pubkey.cpp:210:38#18033 GetMappedAS(...) lookup on an IPv6 address against a maliciously constructed AS-map triggers heap buffer-overflow#18046 Some fuzzing crashes when running under ASan and/or UBSan#18090 gui: Crash if shutdown during processNewTransaction#18362 gui: segfault unloading and immediately reloading wallet with gui#18372 sanitizer: heap-use-after-free in checkinputs_test#18456 bitcoin-qt/bitcoind crashes upon startup of crypto/sha256_shani. Illegal instruction#18706 crash briefly after launching binaries compiled using --without-gui and --with-incompatible-bdb#18762 fuzz: AddressSanitizer: SEGV on unknown address in /strprintf#18763 fuzz: AddressSanitizer: container-overflow in /script fuzzer#18913 ci: fuzz/process_message fails#18924 QT Crash when using open wallet dialog#18948 qt: Call setParent() in the parent's context#19024 UB: double lock of mutex in init.cpp#19049 test: Potential deadlock in wallet_tests/CreateWalletFromFile#19211 feature_reindex.py triggers data race#19353 Fix mistakenly swapped "previous" and "current" lock orders#19417 Intermittent CI failure: ThreadSanitizer failure (data race) when running wallet_multiwallet.py --usecli#19448 qa: Data race detected when running `mempool_expiry.py`#19678 UBSan warning when fuzzing with -fsanitize=integer#19715 ThreadSanitizer: data race in feature_reindex.py#19789 fuzz: ASAN complaint on macOS with -fsanitize=fuzzer,address,undefined#19955 test: Potential deadlock in wallet_tests#20089 validation: Increase robustness when loading malformed mempool.dat files (LoadMempool)#20163 TSAN race after merge of #20090#20181 Wrong `time` when importing transactions with `rescanblockchain ` RPC command#20242 fuzz: Properly initialize PrecomputedTransactionData#20334 ci: fuzz/decode_tx fails#20542 Unexpected test fail: wallet/wallet.cpp:3113:51: runtime error: division by zero#20618 Data race in interface_zmq.py#20844 test: Add sanitizer suppressions for AMD EPYC CPUs#20914 Null pointer derefence in CBlockIndexWorkComparator::operator() reachable via RPC call invalidateblock#21466 Avoid use of "socket" syscall when formatting IP addresses in CNetAddr::ToString#21479 fuzz: UndefinedBehaviorSanitizer warnings in netbase.cpp#21584 Fix assumeutxo crash due to invalid base_blockhash#21586 test: Add missing suppression for signed-integer-overflow:txmempool.cpp#21605 wallet: Segmentation fault during sync#21632 MemorySanitizer: use-of-uninitialized-value in sqlite3BtreeOpen#21773 fuzz: Ensure prevout is consensus-valid#21802 refactor: Avoid UB in util/asmap (advance a dereferenceable iterator outside its valid range)#21948 test: Fix off-by-one in mockscheduler test RPC#22233 fuzz: UndefinedBehaviorSanitizer warnings in consensus/tx_verify.cpp#22537 UndefinedBehaviorSanitizer: implicit-integer-sign-change consensus/tx_verify#22548 CheckQueue_Correct_Random data race#22588 Cirrus CI showed error in netaddress.cpp file when checking PR#22592 LeakSanitizer detects memory leak if CDBWrapper ctor fails#23160 test_bitcoin-qt error: "Unable to init server: Could not connect: Connection refused"#23248 Bitcoin Core crashes under clang-13 libc++ with "Bad system call (core dumped)"#23321 bitcoind segfault's while loading tr descriptor on regtest v22.0#24290 segfault when compiled with depends DEBUG=1 and libc++#24340 util: Add missing unlinkat to syscall sandbox#24426 test: Fix intermittent Tsan issue#24819 data race in SimpleRoundTripTest logging for macOS#25077 Fix chain tip data race and corrupt rest response#25146 Starting with an unsupported wallet configured leads to a segfault (master only?)#25323 miniscript fuzzer failing after qa-assets update#25365 ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) in BaseIndex#25632 SUMMARY: ThreadSanitizer: SEGV src/index/base.cpp:388:9 in BaseIndex::SetBestBlockIndex(CBlockIndex const*)::$_1::operator()() const#25692 psbt.h:896:51: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long'#25824 UndefinedBehaviorSanitizer: stack-overflow in miniscript (descriptor_parse)#25857 IBD core dumped during recursive call to CCoinsViewCache::FetchCoin (while connecting best chain tip)#25895 importdescriptors hanging on importing/updating descriptor with large range#26068 Segmentation fault in the scheduler thread when an index fails to commit to the db#26274 bitcoind dumps core when deriveaddresses is called with index 2147483647 (2^31-1)#26477 validation: fix broken maxtipage comparison#27007 decodescript could infer miniscript from given script in "segwit" context#27051 every other change address is unused#27222 test: use-of-uninitialized-value in sqlite3Strlen30#27235 Avoid integer overflow in CheckDiskSpace#27354 wallet: Data race in GetOrCreateLegacyScriptPubKeyMan vs IsMine#27355 index: ThreadSanitizer: data race on vptr #27360 ci: use LLVM/clang-16 in native_asan job#27492 ci: failure in Docker build step#27582 TSAN: lock-order-inversion (potential deadlock) in ZapSelectTx test#27741 Spurious (?) valgrind failure for p2p_compactblocks.py#27922 ci: fix llvm-symbolizer in MSAN jobs#27924 fuzz: banman, Assertion `banmap == banmap_read' failed#28510 migratewallet crashes on an freshly created datadir ( wallet/wallet.h:959: int wallet::CWallet::GetLastBlockHeight() const: Assertion `m_last_block_processed_height >= 0' failed.)#28570 fuzz: msan fuzz CI currently broken on x86_64#28665 'std::out_of_range' crash in I2P fuzz test#28797 Wallet Missing Balances/Unspent#28917 fuzz, parse_iso8601: attempt to dereference an end-of-stream istreambuf_iterator#28918 fuzz, coinselection: Assertion 'result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0' failed#28966 test: Add missing CBlockPolicyEstimator::processBlockTx suppression#28969 fuzz: Avoid signed-integer-overflow in wallet_notifications fuzz target#29153 new crash in v26.0#29178 ubsan: misaligned-pointer-use in crc32c/src/crc32c_arm64.cc#29767 ThreadSanitizer: data race src/flatfile.cpp:47:13 in FlatFileSeq::Open(FlatFilePos const&, bool)#29908 test: SegFault in `ismine_tests` on SunOS / illumos#30057 ci: msan use-of-uninitialized-value when -jobs=1 (or higher)#30284 Mini miner `AncestorFeerateComparator` Signed Integer Overflow#30402 Illegal Instruction in `CoinStatsIndex::CustomAppend`#30760 ci: fuzz_msan failed with ==4201==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55f0c9bdeffb in SetArgs#30792 ci: failure in win64 unit tests `err:virtual:virtual_alloc_first_teb wine: failed to map the shared user data: c0000018\n0444:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.\n0444:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."`)#30969 win64-cross CI timeout: `wine: chdir to /tmp/wine-JFrcnM/server-30-e86edd : No such file or directory`; `01e0:err:module:relocate_ntdll ntdll could not be mapped at preferred address (0x320000), expect trouble`#31203 fuzz: fix `implicit-integer-sign-change` in wallet_create_transaction#31234 fuzz: connman target: terminate called after throwing an instance of 'std::bad_alloc'#31591 Fuzz: Runtime errors when running fuzz tests on MacOs#31618 multiprocess: `ipc_tests` fail on *BSD#31921 intermittent ipc_tests (Timeout)#32089 Failure to run Fuzz tests when running with corpus#32111 wallet: migratewallet crashes "Assertion `m_wallet_flags == 0' failed"#32112 wallet: migratewallet crashes "Assertion `legacy_spkm' failed"#32173 validation: `CheckBlockIndex` crashes during block reconsideration#32374 test: interface_usdt_net.py failure under --valgrind#32558 intermittent issue in qt addressBookTests: (table_view->model()->rowCount()): [3 != 2] Loc: [./qt/test/addressbooktests.cpp(183)]#32780 lsan: add more Qt suppressions#32957 SegFault in QSortFilterProxyModelPrivate::build_source_to_proxy_mapping#33063 util: Revert "common: Close non-std fds before exec in RunCommandJSON"#33097 fuzz: `txgraph`: Assertion `cmp == 0' failed#33150 intermittent TSAN failure in lockmanager_tests::blockmanager_readblock_hash_mismatch#33245 integer sanitizer warning, when running with -natpmp=1 enabled#33277 intermittent Segmentation fault in mptest IPC path (callFnAsyncParams)#33548 `test_bitcoin-qt`: segfault under LTO (CMAKE_INTERPROCEDURAL_OPTIMIZATION=ON)#33615 ASAN use-after-free in `m_reconnections`#33949 ubsan: add another suppression for InsecureRandomContext#33964 Startup crash on macOS with GCC 15.2: `std::source_location::file_name()` is `nullptr`#34014 mptest hangs, when run in a loop#34109 refactor: Use uint64_t over size_t for serialize corruption check in fees.dat#34110 scriptpubkeyman fuzz target creates Base58 too large; Fails on 32-bit (armhf, ...)#34645 oss-fuzz: coins_view_overlay: ASSERT: m_dirty_count == 0#34655 fuzz: keep `coins_view` fuzzers within caller contracts#34711 src/ipc/libmultiprocess/src/mp/proxy.cpp:416:44: runtime error: member access within null pointer of type 'mp::Waiter'#34732 i386 segv in #0 0xf7a49ce0 in kj::operator*(kj::_::Stringifier, kj::Exception const&) (/lib/i386-linux-gnu/libkj-1.1.0.so+0x38ce0)#34734 test: Fix shutdown vptr race in BlockFilterIndexSync bench#34756 ipc: AddressSanitizer: SEGV nptl/pthread_mutex_lock.c:80:23 in __pthread_mutex_lock#34777 ipc: AddressSanitizer: heap-use-after-free in `capnp::CallContext<ipc::capnp::messages::BlockTemplate::GetBlockParams, ipc::capnp::messages::BlockTemplate::GetBlockResults>::getParams()`#34782 mptest: mp::CancelMonitor: AddressSanitizer: stack-use-after-return#34988 rpc: fix initialization-order-fiasco by lazy-init of decodepsbt_inputs#35104 release: Checksum mismatch in `guix-codesign` log
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-03 03:16 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me