Intentional bug #3 to test #5006. #5009

1. 
   sipa commented at 5:45 pm on September 30, 2014: member

   This was an actual bug in #4926.
2. depends: update the comparison tool to a more recent version 6d7a0fa4e5
3. Revert "travis: retry tests before giving up"

   This reverts commit 7e3821c097c05a4790abac53ddd26ef28cb7cf4d.

   e166c177bc
4. Do merkle root and txid duplicates check simultaneously

   Move the txid duplicates check into BuildMerkleTree, where it can be done
   much more efficiently (without needing to build a full txid set to detect
   duplicates).
   
   The previous version (using the std::set<uint256> to detect duplicates) was
   also slightly too weak. A block mined with actual duplicate transactions
   (which is invalid, due to the inputs of the duplicated transactions being
   seen as double spends) would trigger the duplicates logic, resulting in the
   block not being stored on disk, and rerequested. This change fixes that by
   only triggering in the case of duplicated transactions that can actually
   result in an identical merkle root.

   f6ef959358
5. Broken 2b9750eb5d
6. sipa force-pushed on Sep 30, 2014
7. 
   sipa commented at 8:07 pm on September 30, 2014: member

   Rebased on top of #5006 to expose its ability to detect this error.
8. 
   BitcoinPullTester commented at 8:18 pm on September 30, 2014: none

   Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p5009_2b9750eb5d54bd284b77ce93e5b2a97574973ea7/ for binaries and test log.

   This could happen for one of several reasons:

   1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
   2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
   3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
   4. The test suite fails on either Linux i386 or Win32
   5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

   If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

   This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

9. sipa renamed this:
   Earlier (broken) version of #4926
   Intentional bug #3 to test #5006.
   on Sep 30, 2014
10. sipa closed this on Sep 30, 2014

    ---

11. DrahtBot locked this on Sep 8, 2021

Contributors
sipa BitcoinPullTester