tests: fix python test-runner for windows #5014

pull theuni wants to merge 1 commits into bitcoin:master from theuni:win-test-fix changing 5 files +32 −19

theuni commented at 9:14 PM on September 30, 2014: member
Windows needed a few fixups to get the python tests running:
1. bitcoin-tx needs a file extension in Windows. Take this opportunity to add an env file, which pulls variables out of our build config. This can be extended as needed, for now it's very simple.
2. After #1, split the args out of the exec key in the test data.
3. Correct the line-endings from windows stdout

tests: fix python test-runner for windows

Windows needed a few fixups to get the tests running:
1. bitcoin-tx needs a file extension in Windows. Take this opportunity to
   add an env file, which pulls variables out of our build config. This can
   be extended as needed, for now it's very simple.
2. After #1, split the args out of the exec key in the test data.
3. Correct the line-endings from windows stdout

41d67c78bf

theuni commented at 9:21 PM on September 30, 2014: member

@jgarzik Not sure how you'd prefer to have this handled, so I took a stab at it. I'm happy to rework the approach if you'd like.

After this one and a few other minor fixes, we'll be able to enable tests for windows on travis.
jgarzik commented at 9:25 PM on September 30, 2014: contributor

@theuni Your solution is just fine. ut ACK

Future tests wanted the separation of executable and argument-list for multiple-invocation testing, so that bit was desireable on its own, too.
BitcoinPullTester commented at 9:57 PM on September 30, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p5014_41d67c78bf66c8c171947148e18b9ec01768ba65/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 6:49 AM on October 1, 2014: member

ACK
laanwj merged this on Oct 1, 2014
laanwj closed this on Oct 1, 2014
laanwj referenced this in commit a6f3e9d843 on Oct 1, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#1 JSON-RPC support for mobile devices ("ultra-lightweight" clients)#5098 Add buildenv.py to gitignore