Add Paper Wallet Generation in Bitcoin Core #5058

pull whitj00 wants to merge 4 commits into bitcoin:master from Andymeows:master changing 19 files +840 −5
  1. whitj00 commented at 6:22 PM on October 7, 2014: contributor

    Ported by @andymeows and @whitj00 from @andymeows' dogecoin implementation.

    Tested on Mac, Windows, and Linux with qt4 and qt5

    Includes warning if computer is connected to Internet.

    While not optimal, it is better than using a website like brainwallet.org and anything that makes cold storage easier for the average user is good IMO.

    This is likely controversial and I am open to discussion on how to improve this.

  2. Adding base changes from Dogecoin implementation 3eca82da7e
  3. Add Paper Wallet Image 367095b2c3
  4. Change Doge Wording 6fdf638f10
  5. whitj00 closed this on Oct 7, 2014

  6. whitj00 commented at 6:48 PM on October 7, 2014: contributor

    I'll fix the missing image

  7. luke-jr commented at 7:45 PM on October 7, 2014: member

    NACK, when/if we add this, it should be a real paper wallet, not a single ECDSA private key. It would also be good to have paper wallet support merged before we start making them, too...

  8. whitj00 commented at 10:05 PM on October 7, 2014: contributor

    I'm assuming you mean deterministic paper wallets?

    On Oct 7, 2014, at 12:46 PM, Luke-Jr notifications@github.com wrote:

    NACK, when/if we add this, it should be a real paper wallet, not a single ECDSA private key. It would also be good to have paper wallet support merged before we start making them, too...

    — Reply to this email directly or view it on GitHub.

  9. Add Print Icon 5bc7fb094e
  10. whitj00 reopened this on Oct 7, 2014

  11. luke-jr commented at 12:02 AM on October 8, 2014: member

    @whitj00 I'm not aware of any other way to make actual paper wallets. A single key/address is not a wallet.

  12. whitj00 commented at 12:05 AM on October 8, 2014: contributor

    @luke-jr ok, makes sense. I think I did see HD paper wallets before, but thats useless in bitcoin core until we implement it.

    What is the objection to including it? I understand that there are more optimal ways to do it, but until those are practical, wouldn't any feature that makes it easier to secure their coins be beneficial.

  13. luke-jr commented at 12:09 AM on October 8, 2014: member

    Users are not supposed to ever work with individual keys, and there is no safe way for them to do so. Even if one foolishly ignores the many issues with address reuse, micromanaging individual keys requires a strong understanding of the Bitcoin system. For example, I wouldn't even trust myself to properly/safely manage individual keys.

  14. laanwj commented at 7:00 AM on October 8, 2014: member

    I do like the concept.

    But in any case, due to its insistence on being synced to the network, Bitcoin Core is not a good online/offline wallet. Its utility for something like paper wallets is very limited, as any paper wallet you create will already be potentially 'spoiled' by being connected to the internet.

    Have you looked at armory?

  15. laanwj commented at 7:01 AM on October 8, 2014: member

    Maybe we should turn this into a separate key generation + printing utility? An external utility that you can run on a non-internet-connected PC. This idea has been brought up before, but now that we have an implementation this is easier to do.

  16. laanwj added the label Wallet on Oct 8, 2014
  17. whitj00 commented at 4:36 PM on October 8, 2014: contributor

    An external one exists, bitaddress, and breainwallet. The current main issue with paper wallets in my opinion is that they're to complicated to do safely for the average user. They end up using an online service, that has ma vulnerabilities.

    This is why it should be built into core, and not armory, which is aimed at advanced users.

    This WArns you that you should disconnect from the internet, and this works (and is preferred) on a offline PC

  18. laanwj commented at 5:50 PM on October 8, 2014: member

    Don't forget that Bitcoin Core is also aimed at advanced users. Average users would better use multibit, or electrum.

  19. imharrywu commented at 11:45 PM on October 8, 2014: contributor

    paper wallet may require BIP or a standard to discussed, such as format, storage, etc., as there are many parties take care of this standard.

  20. luke-jr commented at 11:56 PM on October 8, 2014: member
  21. whitj00 commented at 12:58 AM on October 9, 2014: contributor

    @luke-jr, the issue is that bitcoin core doesn't support mnemonics. A similar feature like this would be great in electrum, but until bitcoin core does, it doesn't make sense to use bip-39

  22. whitj00 commented at 1:00 AM on October 9, 2014: contributor

    @laanwj agreed, but bitcoin core is not exclusively used by advanced users.

    Many merchants I've spent BTC at use bitcoin core, because of issues with multi bit or another spv wallet, or because they need a full chain for whatever reason.

    I've never seen a merchant using armory (i'm sure theres a few though)

    Would it be preferable to make this feature only accessible offline?

  23. luke-jr commented at 1:24 AM on October 9, 2014: member

    @whitj00 Yes, that was my original point: it doesn't make sense to have this in any form in Bitcoin Core right now.

  24. laanwj commented at 7:40 AM on October 9, 2014: member

    @whitj00 But it doesn't really make sense to use Bitcoin Core offline. It's a full node, it needs to be online. You'd never run it on a computer that is not connected to the internet. That's why I suggested a separate tool. It could still be packaged and released as part of Bitcoin Core, but it would be a separate executable that has no network connectivity at all.

  25. whitj00 commented at 6:36 PM on October 19, 2014: contributor

    @laanwj it would be interesting to see what percentage of people use bitcoinpaperwallet online.

  26. whitj00 renamed this:
    Add Paper Wallet Generation from Bitcoin Core
    Add Paper Wallet Generation in Bitcoin Core
    on Oct 19, 2014
  27. jonasschnelli commented at 12:51 PM on March 11, 2015: contributor

    I also think this should not go into bitcoin-core. A standalone paper wallet generation app would def. make much more sense. It makes no sense to generate a offline paper wallet within a app that serves/acts as a full node.

    Should be closed IMO.

  28. laanwj closed this on Mar 18, 2015

  29. laanwj commented at 1:53 PM on March 18, 2015: member

    I also think this should not go into bitcoin-core. A standalone paper wallet generation app would def. make much more sense. It makes no sense to generate a offline paper wallet within a app that serves/acts as a full node.

    Exactly. It's useful functionality, but just doesn't fit in the goal of this software.

  30. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me