Removed alert system from main.cpp #506

pull enmaku wants to merge 1 commits into bitcoin:master from enmaku:master changing 1 files +0 −16

enmaku commented at 6:45 AM on September 8, 2011: contributor

Even though it no longer triggers RPC safe mode there is some concern that it could still be misused. Signed-off-by: David Perry enmaku@gmail.com

Removed the alert system

Even though it no longer triggers RPC safe mode there is some concern that it could still be misused.
Signed-off-by: David Perry <enmaku@gmail.com>

f1f0fcb2e4

gavinandresen commented at 1:22 PM on September 8, 2011: contributor

There is concern by who?

I strongly believe that the ability to broadcast a message in case of emergency is important; before removing it, generate some consensus on the bitcoin-dev mailing list that removing it is a good idea (I'll argue against).
enmaku commented at 2:24 PM on September 8, 2011: contributor

I was simply going off the comments on the Bitcoin StackExchange. I believe the primary concern was that it could be used for spam/DoS. I'll gladly submit the idea to the mailing list for consensus.
alexwaters commented at 4:04 PM on September 8, 2011: contributor

I believe this is in reference to http://bitcoin.stackexchange.com/questions/740/how-can-the-alert-system-be-triggered-who-can-do-it and http://bitcoin.stackexchange.com/questions/636/is-the-alert-system-still-in-the-main-clients-code-will-it-be-removed

I'm not really for removing it, but there's always the Git history if we want to revive and improve it to be more decentralized down the road.
enmaku commented at 4:10 PM on September 8, 2011: contributor

That's correct Alex. There's a discussion on the Bitcoin-Dev mailing list if you've got input to add: http://sourceforge.net/mailarchive/forum.php?thread_name=CAOPxoMv7EGwgBNuvYpaD_4LtyxUUCvQ2Pe0DCZO4uHoAoMyfnA%40mail.gmail.com&forum_name=bitcoin-development
alexwaters closed this on Sep 8, 2011
alexwaters commented at 4:44 PM on September 8, 2011: contributor

It seems that public opinion is that the code should remain for the time being. Closing this request until there are additional commits or more support in the mailing list/forums.
enmaku commented at 6:32 PM on September 8, 2011: contributor

Fair enough. Sounds like there's some good discussion about the alert system at least so I don't consider my time to have been wasted bringing it up :)
ptschip referenced this in commit a46bbb9324 on May 3, 2017
fjahr referenced this in commit dbc3ddd5e2 on Jul 24, 2019
lateminer referenced this in commit 71e2394f45 on Jul 17, 2020
rajarshimaitra referenced this in commit c7ab404485 on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels