Move rounding #51

pull davout wants to merge 1 commits into bitcoin:master from davout:move-rounding changing 1 files +7 −3
  1. davout commented at 10:11 pm on January 30, 2011: none

    I think it’s important that the “move” command handles subcent transactions without silently rounding amounts at two decimal places.

    It is common in a lot of cases to handle these small amounts (bitcoin central for example).

    I want to keep using it as a second security level on bitcoin central, but right now it’s not possible because the DB-tracked accounts slowly get out of sync with the bitcoin ones, and at some points transaction get rolled back because some bitcoin account does not have enough funds whereas the DB-tracked one has enough credit to complete the transaction.

    If I try to move 0.001 BTC between two accounts I get a “true” returned even though I should have gotten an “Invalid amount” with the previous round-everything approach since nothing would have changed.

    With this, rounding is only disabled for the “move” command.

  2. Accounts should be able to track sub-cent amounts with the move command abe5672347
  3. gavinandresen commented at 1:28 pm on January 31, 2011: contributor
    Nice! I’d like to make this part of a set of changes for the 0.3.21 release to deal with sub-bitcent amounts consistently across all the RPC methods and in the GUI.
  4. davout commented at 2:28 pm on January 31, 2011: none

    Would it be possible to pull it in for 0.3.20 ? I’d really like that in order to keep the double balance check that occurs on BC before any transfer.

    Also is there a way to manually fiddle with account balances other than moving bitcoins around until achievement of desired accounts statuses ?

  5. gavinandresen commented at 10:01 pm on February 23, 2011: contributor
    See: #79
  6. gavinandresen commented at 2:43 am on March 3, 2011: contributor
    I pulled the more generic rounding patch.
  7. kac- referenced this in commit e385beaedd on Jun 10, 2014
  8. rdponticelli referenced this in commit e2beb0bd2d on Nov 26, 2014
  9. dexX7 referenced this in commit a1a39f2601 on May 25, 2015
  10. ptschip referenced this in commit 056ea28a20 on Jul 22, 2016
  11. CryptAxe referenced this in commit c590d6ed24 on Nov 15, 2017
  12. CryptAxe referenced this in commit fe6da6fc4a on Dec 28, 2017
  13. classesjack referenced this in commit 17dca4b1a5 on Jan 2, 2018
  14. effectsToCause referenced this in commit 50e55ceeac on Jun 22, 2018
  15. satindergrewal referenced this in commit b57fd92ad2 on Jun 22, 2021
  16. rajarshimaitra referenced this in commit 07d17b48ff on Aug 5, 2021
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me