Setting the Chain::SetTip return type to void. No other use case identified.
Chain::SetTip return type to void #5104
pull ghost wants to merge 1 commits into bitcoin:master from changing 2 files +4 −5-
ghost commented at 1:57 AM on October 20, 2014: none
-
luke-jr commented at 2:15 AM on October 20, 2014: member
Just because it's not used doesn't mean it should be void'd...
-
laanwj commented at 9:23 AM on October 20, 2014: member
I don't really have an opinion on this. On one hand it indeed makes no sense to return something that isn't used, on the other hand it's not like this allows removing a significant amount of dead code, and it may come in useful later.
-
sipa commented at 6:07 PM on October 20, 2014: member
utACK - I added the return value because it was cheap and sounded potentially useful, but I doubt it will be used.
Please squash the commits though.
-
Chain::SetTip return type to void b7ae2c172a
-
ghost commented at 12:35 AM on October 21, 2014: none
Squashed as requested.
- laanwj merged this on Oct 22, 2014
- laanwj closed this on Oct 22, 2014
- laanwj referenced this in commit 93cb689e52 on Oct 22, 2014
- MarcoFalke locked this on Sep 8, 2021
