Only include undo.h from main.cpp #5111

1. 
   jtimon commented at 6:30 am on October 21, 2014: contributor

   Built on top of #5100. coins.o doesn’t need to depend on undo.h (Decouple CCoins from CTxInUndo) miner.o neither (Decouple miner.o from CTxUndo) Finally, CBlockUndo can be moved from main.h to undo.h if it is first decoupled from CDiskBlockPos.
2. jtimon force-pushed on Oct 21, 2014
3. laanwj added the label Improvement on Oct 22, 2014
4. jtimon force-pushed on Oct 23, 2014
5. jtimon force-pushed on Oct 27, 2014
6. jtimon renamed this:
   Decouple CCoins from CTxInUndo
   Only include undo.h from main.cpp
   on Oct 27, 2014
7. jtimon force-pushed on Oct 28, 2014
8. 
   jtimon commented at 1:33 pm on October 28, 2014: contributor

   Rebased to make it more readable.
9. 
   sipa commented at 3:40 pm on October 29, 2014: member

   utACK!
10. jtimon force-pushed on Oct 30, 2014
11. 
    jtimon commented at 12:11 pm on October 30, 2014: contributor

    Nits addressed.
12. 
    sipa commented at 1:35 pm on November 4, 2014: member

    Needs rebase.
13. jtimon force-pushed on Nov 5, 2014
14. 
    jtimon commented at 10:42 am on November 5, 2014: contributor

    Rebased and squashed the commits solving the nits.
15. 
    sipa commented at 2:08 pm on November 18, 2014: member

    utACK still
16. jtimon force-pushed on Nov 21, 2014
17. 
    jtimon commented at 2:47 pm on November 21, 2014: contributor

    Needed rebase for the doxygen comments.
18. jtimon force-pushed on Dec 2, 2014
19. 
    jtimon commented at 10:46 pm on December 2, 2014: contributor

    Rebased adding @theuni ’s suggestions.
20. in src/main.cpp: in 3e5c96b106 outdated

    1508+    CHashWriter hasher(SER_GETHASH, PROTOCOL_VERSION);
    1509+    hasher << hashBlock;
    1510+    hasher << blockundo;
    1511+    fileout << hasher.GetHash();
    1512+
    1513+    // Flush stdio buffers and commit to disk before returning
    

    ---

    ---

    

    sipa commented at 11:11 pm on December 2, 2014:

    This part was removed in head.
21. jtimon force-pushed on Dec 2, 2014
22. 
    jtimon commented at 11:40 pm on December 2, 2014: contributor

    Sorry, mistake rebasing…
23. jtimon force-pushed on Dec 9, 2014
24. 
    jtimon commented at 3:29 pm on December 9, 2014: contributor

    Rebased
25. jtimon force-pushed on Dec 9, 2014
26. Decouple CCoins from CTxInUndo c444c620c6
27. Decouple miner.o and txmempool.o from CTxUndo d7621ccf9d
28. Decouple CBlockUndo from CDiskBlockPos e035c6a737
29. MOVEONLY: CBlockUndo from main.h to undo.h 937ba572d0
30. Move UndoWriteToDisk() and UndoReadFromDisk() to anon namespace 87fb31086d
31. jtimon force-pushed on Dec 27, 2014
32. 
    jtimon commented at 3:03 pm on December 27, 2014: contributor

    Rebased again. Like miner.cpp, txmempool.cpp was now also unnecessarily coupled with CTxUndo.
33. 
    jgarzik commented at 11:49 am on December 31, 2014: contributor

    ACK
34. jgarzik merged this on Dec 31, 2014
35. jgarzik closed this on Dec 31, 2014

    ---

36. jgarzik referenced this in commit aa5c0d34b7 on Dec 31, 2014
37. furszy referenced this in commit 128978d45b on Jul 16, 2020
38. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon sipa jgarzik

Labels
Refactoring