Policy: Move CTxOut::IsDust() to policy.o #5114
pull jtimon wants to merge 2 commits into bitcoin:master from jtimon:dust changing 24 files +122 −94-
jtimon commented at 7:32 am on October 21, 2014: contributor
-
in src/chainparams.h: in 75c9668bed outdated
5@@ -6,8 +6,8 @@ 6 #ifndef BITCOIN_CHAIN_PARAMS_H 7 #define BITCOIN_CHAIN_PARAMS_H 8 9-#include "core.h" 10 #include "chainparamsbase.h" 11+#include "core/block.h"
Diapolo commented at 10:32 am on October 21, 2014:Nit: Should be below checkpoints.in src/compressor.cpp: in 75c9668bed outdated
142+ if (e < 9) { 143+ int d = (n % 10); 144+ assert(d >= 1 && d <= 9); 145+ n /= 10; 146+ return 1 + (n * 9 + d - 1) * 10 + e; 147+ } else {
Diapolo commented at 10:34 am on October 21, 2014:This else could just be removed as it’s the last return anyway.
jtimon commented at 7:43 pm on October 21, 2014:But it’s not something I want to change in a MOVEONLY commit.in src/core/transaction.cpp: in 75c9668bed outdated
10+std::string COutPoint::ToString() const 11+{ 12+ return strprintf("COutPoint(%s, %u)", hash.ToString().substr(0, 10), n); 13+} 14+ 15+CTxIn::CTxIn(COutPoint prevoutIn, CScript scriptSigIn, uint32_t nSequenceIn)
Diapolo commented at 10:38 am on October 21, 2014:Just wondering, why arent’t these references?
jtimon commented at 7:43 pm on October 21, 2014:Again, not something I want to change in a MOVEONLY commit.in src/init.cpp: in 75c9668bed outdated
8@@ -9,6 +9,7 @@ 9 10 #include "init.h" 11 12+#include "amount.h"
Diapolo commented at 10:39 am on October 21, 2014:Nit: Should be below addrman.jtimon force-pushed on Oct 21, 2014laanwj added the label Improvement on Oct 22, 2014jtimon force-pushed on Oct 23, 2014jtimon force-pushed on Oct 27, 2014jtimon force-pushed on Oct 28, 2014jtimon commented at 1:31 pm on October 28, 2014: contributorRebased to make it more readable.sipa commented at 3:37 pm on October 29, 2014: memberIf you’re moving it, can you move it to main instead? It really doesn’t belong in core..jtimon force-pushed on Oct 30, 2014jtimon force-pushed on Oct 30, 2014jtimon commented at 12:28 pm on October 30, 2014: contributorMoved it to policy.o, where I think it belongs.sipa commented at 1:34 pm on November 4, 2014: memberutACKjtimon force-pushed on Dec 27, 2014jtimon commented at 5:37 pm on December 27, 2014: contributorNeeded rebase (was including core/transaction instead of privitives/transaction).petertodd commented at 10:12 am on December 28, 2014: contributorutACKjtimon force-pushed on Dec 29, 2014jtimon commented at 2:12 pm on December 29, 2014: contributorAdded a couple of potential improvements to comment on (moving global minRelayTxFee from main to policy and hiding it for IsDust() calls). Also it needed a small include rebase.jtimon force-pushed on Dec 29, 2014jtimon force-pushed on Dec 29, 2014petertodd commented at 4:20 am on January 3, 2015: contributorutACKjtimon force-pushed on Jan 3, 2015jtimon renamed this:
Turn CTxOut::IsDust() into an independent function
Move CTxOut::IsDust() to policy.o
on Jan 3, 2015jtimon renamed this:
Move CTxOut::IsDust() to policy.o
Policy: Move CTxOut::IsDust() to policy.o
on Jan 3, 2015sipa commented at 3:19 pm on January 4, 2015: memberUntested ACKlaanwj added the label TX fees and policy on Jan 8, 2015jtimon force-pushed on Jan 12, 2015jtimon force-pushed on Jan 12, 2015jtimon force-pushed on Jan 21, 2015jtimon force-pushed on Jan 21, 2015jtimon closed this on Jan 21, 2015
jtimon reopened this on Jul 12, 2015
jtimon force-pushed on Jul 12, 2015jtimon force-pushed on Jul 16, 2015Policy: Refactor: CTxOut::IsDust(CFeeRate) -> CPolicy::ValidateOutput(CTxOut)
Decouples CTxOut from CFeeRate Simplifies IsDust() interface encapsulating the access to global minRelayTxFee
MOVEONLY: Consensus: Policy: Move CFeeRate from amount.o to policy/fees.o e2851a2c8cjtimon force-pushed on Jul 16, 2015jtimon commented at 6:36 pm on July 20, 2015: contributorNeeds rebase and I’m thinking about moving the functions to the fee estimator (policy/fees) instead of policy/policy, so closing for now.jtimon closed this on Jul 20, 2015
DrahtBot locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me