Clear vFixedSeeds for regtest network #5133

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_10_regtest_fixed_seeds changing 1 files +1 −0

laanwj commented at 7:34 AM on October 24, 2014: member

It shouldn't inherit these from testnet. (seems to be already done for unit test network but forgotten here...)
laanwj added the label Tests on Oct 24, 2014

Clear vFixedSeeds for regtest network

It shouldn't inherit these from testnet.
(seems to be already done for unit test network but forgotten here...)
Fixes #5127.

7c0f36c431

laanwj force-pushed on Oct 24, 2014
gavinandresen commented at 2:50 PM on October 24, 2014: contributor
I'm still getting connection attempts with a regtest, listening node:
```
node0/regtest/debug.log:2014-10-24 14:47:00 Cannot connect to thfsmmn2jbitcoin.onion:18333: unsupported network
node0/regtest/debug.log:2014-10-24 14:47:05 Cannot connect to it2pj4f7657g3rhi.onion:18333: unsupported network
```
... after running qa/rpc-tests listtransactions.py --nocleanup and looking in the test directory.
laanwj commented at 3:05 PM on October 24, 2014: member
@gavinandresen Strange - I cannot reproduce this
```
bitcoin2/qa/rpc-tests$ python listtransactions.py --nocleanup
Initializing test directory /tmp/testqe2d0n
Tests successful

bitcoin2/qa/rpc-tests$ grep onion /tmp/testqe2d0n/*/regtest/debug.log
[no output]
```
Those two onion addresses really come from the testnet onion seed list, but I can't imagine how they can still affect things after clearing the seed list for regtest.
gavinandresen commented at 5:45 PM on October 24, 2014: contributor

It is a bug in the regression tests-- I had an old peers.dat in the qa/rpc-tests/cache/

ACK on this fix, I'll fix the regression test bug (remove peers.dat from cache/)
gavinandresen referenced this in commit 46df9c3b42 on Oct 24, 2014
gavinandresen merged this on Oct 24, 2014
gavinandresen closed this on Oct 24, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels