Start with tidier RPC-test cache directories #5139

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:rpc_cache_cleanup changing 1 files +7 −4

gavinandresen commented at 7:54 PM on October 24, 2014: contributor

Remove more files from the cached, 200-block-chain data directories. An old peers.dat caused me confusion when testing the -regtest-uses-.onion-seeds bug.

Start with tidier cache directories

Remove more files from the cached, 200-block-chain data directories.

9f87325b22

laanwj commented at 8:24 AM on October 27, 2014: member

ACK
in qa/rpc-tests/util.py:None in 9f87325b22
```
 117 |          for i in range(4):
 118 | -            os.remove(debug_log("cache", i))
 119 | +            os.remove(log_filename("cache", i, "debug.log"))
 120 | +            os.remove(log_filename("cache", i, "db.log"))
 121 | +            os.remove(log_filename("cache", i, "peers.dat"))
 122 | +            os.remove(log_filename("cache", i, "fee_estimates.dat"))
```
laanwj commented at 9:20 AM on October 27, 2014:

Slight concern: os.remove fails when the file doesn't exist. There may be valid cases in which not all the files are created (ie, db.log won't be created without wallet).

gavinandresen commented at 5:34 PM on October 27, 2014:

Not an issue; If we ever remove the wallet, we'll have to remove most of the rpc tests, because they rely on wallet functionality.

laanwj commented at 5:37 PM on October 27, 2014:

But some RPC test may start the node using -disablewallet?

gavinandresen commented at 5:59 PM on October 27, 2014:

@laanwj : this is the cache/ directory setup code, it starts up nodes just for the purpose of creating an initial blockchain (so tests don't take so long to run). If rpc tests start their own nodes with -disablewallet, it won't affect this code.

laanwj commented at 6:53 PM on October 27, 2014:

You're right, I forgot about that
gavinandresen merged this on Oct 27, 2014
gavinandresen closed this on Oct 27, 2014
gavinandresen referenced this in commit e4f79c0219 on Oct 27, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

gavinandresen

laanwj