fix "too many arguments" error #5141

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:FixGenbuild changing 1 files +1 −1

rebroad commented at 6:37 AM on October 25, 2014: contributor

This produces a "too many arguments" error sometimes without the quotes.
fix "too many arguments" error 313328969a

in share/genbuild.sh:None in 313328969a

  15 | @@ -16,7 +16,7 @@ fi
  16 |  DESC=""
  17 |  SUFFIX=""
  18 |  LAST_COMMIT_DATE=""
  19 | -if [ -e "$(which git 2>/dev/null)" -a $(git rev-parse --is-inside-work-tree 2>/dev/null) = "true" ]; then
  20 | +if [ -e "$(which git 2>/dev/null)" -a $"(git rev-parse --is-inside-work-tree 2>/dev/null)" = "true" ]; then

laanwj commented at 6:43 AM on October 25, 2014:

Shouldn't the quotes be around the entire expression? ie, "$(git rev-parse --is-inside-work-tree 2>/dev/null)"

laanwj closed this on Nov 4, 2014
reddink referenced this in commit 02d9249400 on May 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

rebroad

laanwj