consensus lib work: split CPubKey and friends out of key.o #5162

1. 
   theuni commented at 1:41 am on October 29, 2014: member

   This is the next-to-last major movement necessary for libbitcoinconsensus. After this and version movement (see next PR), only script interpreter error handling remains.

   Split CPubKey and friends out so that they can be used without CKey’s dependencies. Stub files have been created for handling crypto functionality without any core deps (eccryptoverify.h/cpp). Eventually these will handle crypto-level key functions, and CKey/CPubKey will call into them. Because some code changes are needed for that, and it’s not strictly necessary for the verification lib for 0.10, that change has been skipped here.

2. laanwj added the label Improvement on Oct 29, 2014
3. boost: moveonly: create eccryptoverify.h|cpp and move helper functions there

   Eventually (after 0.10) these files will hold the logic for crypto
   verification routines, and CKey/CPubKey will call into them.

   900078aeb4
4. boost: moveonly: move BIP32Hash to hash.h 78c228c6e5
5. theuni force-pushed on Oct 31, 2014
6. boost: moveonly: split CPubKey and friends to new files d2e74c55bd
7. 
   theuni commented at 5:19 am on October 31, 2014: member

   rebased after #5164 and #5148
8. in src/eccryptoverify.h: in d2e74c55bd

   0@@ -0,0 +1,19 @@
   1+// Copyright (c) 2009-2010 Satoshi Nakamoto
   2+// Copyright (c) 2009-2013 The Bitcoin developers
   3+// Distributed under the MIT/X11 software license, see the accompanying
   

   ---

   ---

   

   laanwj commented at 9:28 am on November 3, 2014:

   Please make this just MIT, especially in new files
9. in src/eccryptoverify.cpp: in d2e74c55bd

   47+} // anon namespace
   48+
   49+namespace eccrypto {
   50+
   51+bool Check(const unsigned char *vch) {
   52+    return vch &&
   

   ---

   ---

   

   laanwj commented at 9:30 am on November 3, 2014:

   ACK on adding the null pointer check here (although it’s not move-only)
10. 
    laanwj commented at 9:33 am on November 3, 2014: member

    Verified move-only apart from noted exception above. utACK
11. laanwj merged this on Nov 4, 2014
12. laanwj closed this on Nov 4, 2014

    ---

13. laanwj referenced this in commit 73b82a3089 on Nov 4, 2014
14. MarcoFalke locked this on Sep 8, 2021

Contributors
theuni laanwj

Labels
Refactoring