RFC: Travis rpc tests #5185

pull theuni wants to merge 6 commits into bitcoin:master from theuni:travis-rpc-tests changing 18 files +89 −344
  1. theuni commented at 6:01 AM on October 31, 2014: member

    RFC because I'm not sure it's necessary for each PR. It will add a few min to the test time. Partially addresses #4905 by running them from Travis rather than the local 'make check'

    • fixup tests to run on windows
    • remove old pull-tester scripts that are no longer used
    • add new rpc test scripts
    • hook up rpc tests to travis
  2. tests: enable alertnotify test for Windows
    The semantics of "echo" are different there and they change the resulting text,
    but they're still correct and predictable.
    f635269cd1
  3. tests: allow rpc-tests to get filenames for bitcoind and bitcoin-cli from the environment
    This will allow for windows tests to run with bitcoind.exe and bitcoin-cli.exe
    7a41614aa2
  4. tests: fix forknotify.py on windows
    Windows interprets 'foo.txt' as a literal filename while "foo.txt" is treated
    as expected.
    5122ea7190
  5. tests: remove old pull-tester scripts
    They're unused since the switch to Travis
    fa7f8cdc1a
  6. tests: replace the old (unused since Travis) tests with new rpc test scripts 7667850dbf
  7. add tests to travis 2191eac812
  8. gavinandresen commented at 3:18 PM on October 31, 2014: contributor

    ACK from me.

    RE: adding a few minutes to the test time: I think we should start with more testing at every PR; we can optimize or do a run-expensive-tests-against-git-HEAD-once-a-day if it becomes too much.

  9. laanwj commented at 3:23 PM on October 31, 2014: member

    ACK from me too, it's better to catch problems before merge

  10. theuni commented at 6:06 PM on October 31, 2014: member

    Ok. I picked the current ones (wallet/listtransactions/forknotify) because they were the ones listed for the old pull-tester. Are there any others that should be hooked up initially?

  11. laanwj commented at 8:22 AM on November 3, 2014: member

    No, this is fine. Others can be added later.

  12. laanwj merged this on Nov 3, 2014
  13. laanwj closed this on Nov 3, 2014

  14. laanwj referenced this in commit 2a6972133f on Nov 3, 2014
  15. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me