Unify header defines. #5196

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:header-defines changing 89 files +269 −270

paveljanik commented at 9:30 AM on November 2, 2014: contributor

This change unifies header defines to match the pattern BITCOIN_FILENAME_H and regenerates src/chainparamsseeds.h accordingly.
sipa commented at 9:32 AM on November 2, 2014: member

utACK
Diapolo commented at 11:40 AM on November 2, 2014: none

utACK
laanwj commented at 8:18 AM on November 3, 2014: member
concept ACK, though there's a bit more to do -- see git grep -L BITCOIN_ -- '*.h' (but ignore external libraries such as leveldb, json and tinyformat):
- src/compat/sanity.h (lol)
- src/univalue/*.h
- src/qt/*.h
paveljanik commented at 8:43 AM on November 3, 2014: contributor

What define would you prefer instead of qt/addressbookpage.h:#define ADDRESSBOOKPAGE_H?

I propose BITCOIN_QT_ADDRESSBOOKPAGE_H, ie. starting with BITCOIN_QT_...
laanwj commented at 9:01 AM on November 3, 2014: member

@paveljanik sounds good to me
laanwj commented at 12:38 PM on November 3, 2014: member

ACK after squash
Fix all header defines 84738627ce
paveljanik commented at 3:29 PM on November 3, 2014: contributor

Looks like I screwed something up. I redid all commits as one in clean header-defines2 branch. Sorry.
paveljanik force-pushed on Nov 3, 2014
paveljanik commented at 5:43 PM on November 3, 2014: contributor

PR is now clean and can be used. Thanks Wladimir for helping me fixed the git mess.
laanwj merged this on Nov 4, 2014
laanwj closed this on Nov 4, 2014
laanwj referenced this in commit df504e924a on Nov 4, 2014
paveljanik deleted the branch on Feb 4, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors