log low-level network messages only when fDebug is set #520

pull tcatm wants to merge 2 commits into bitcoin:master from tcatm:less-logging changing 2 files +14 −8

tcatm commented at 4:39 PM on September 17, 2011: none
This patch wraps three debug messages (sending, received and got inventory) in if (fDebug) {...}.

I analyzed debug.log on a few long-running bitcoin nodes and noticed > 80% of debug.log is composed of those three messages. Thus this patch should greatly reduce debug.log size and disk I/O.
- sending is triggered whenever a low-level message is sent (i.e. sending: inv (37 bytes)).
- received is triggered whenever a message is received (i.e. received: inv (37 bytes)).
- got inventory is triggered when an `inv``-message is received.
log low-level network messages only when fDebug is set 59090133c0
missed printf in AbortMessage(); merged printfs in EndMessage e674680ddd
jgarzik commented at 8:25 PM on September 17, 2011: contributor

ACK
gavinandresen commented at 2:20 PM on September 19, 2011: contributor

ACK
tcatm referenced this in commit 2d294e080c on Sep 19, 2011
tcatm merged this on Sep 19, 2011
tcatm closed this on Sep 19, 2011
coblee referenced this in commit a944beecc1 on Jul 17, 2012
dexX7 referenced this in commit 04d16c13e6 on Dec 16, 2017
kallewoof referenced this in commit 406580e2f2 on Oct 4, 2019
lateminer referenced this in commit 1727028b55 on Jul 17, 2020
rajarshimaitra referenced this in commit 857ac2f0f0 on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels