The first thing that SelectParams does is call SelectBaseParams. Therefore, we do not need to call SelectBaseParams immediately prior to calling SelectParams.
minor update to not select base params twice in a row #5203
pull mruddy wants to merge 1 commits into bitcoin:master from mruddy:dev changing 1 files +0 −1-
mruddy commented at 12:34 PM on November 4, 2014: contributor
-
The first thing that SelectParams does is call SelectBaseParams. Therefore, we do not need to call SelectBaseParams immediately prior to calling SelectParams. 0d91ae308c
-
mruddy commented at 3:59 PM on November 7, 2014: contributor
Hi, I'm new around here, does no feedback mean that this request has been rejected? If so, I'll close this request. But, this is such a simple commit, that only removes a single unnecessary call, that I figured it'd be merged in pretty quickly. Thanks!
-
sipa commented at 4:39 PM on November 7, 2014: member
No, it just means that nobody bother to look at it yet. Sorry for that :)
-
theuni commented at 4:39 PM on November 7, 2014: member
Nope, not rejected, just overlooked. Sometimes a quick bump is the right thing to do, and this was one of those cases :)
Untested ACK, assuming it doesn't conflict with the other work happening in this area
-
laanwj commented at 8:59 AM on November 11, 2014: member
The extra call is indeed unnecessary, looks good to me. utACK
- laanwj added the label Improvement on Nov 11, 2014
- laanwj merged this on Nov 13, 2014
- laanwj closed this on Nov 13, 2014
- laanwj referenced this in commit ed98a6284b on Nov 13, 2014
- mruddy deleted the branch on Nov 13, 2014
- MarcoFalke locked this on Sep 8, 2021
Labels