Rearrange initial config checks: AC, AM, compilers, libtool, basic progs... #5214

pull randy-waterhouse wants to merge 1 commits into bitcoin:master from randy-waterhouse:config changing 1 files +29 −38
  1. randy-waterhouse commented at 8:57 AM on November 5, 2014: contributor

    Should be a more logical order of checks, from least dependent functions upwards. Helps with readibility also. Should address also #5195

  2. randy-waterhouse force-pushed on Nov 5, 2014
  3. theuni commented at 11:34 PM on November 5, 2014: member

    @randy-waterhouse Does this actually fix #5195? I'd think that AM_INIT_AUTOMAKE would end up testing for gcc.

    Also, many of those prog checks can just be dropped rather than moved, since libtool checks for them. I was going to PR that change at some point, but this seems like a good time. Looking quickly, I think we can drop:

    AC_PROG_CC AC_PROG_CPP AC_PROG_CXXCPP AC_PROG_INSTALL AC_PROG_OBJC AC_PROG_LN_S AC_PROG_MKDIR_P AC_PROG_SED

  4. Rearrange initial config checks: AC, AM, compiler, libtool.
    Removed some repeated and unused prog checks.
    eefb766c77
  5. randy-waterhouse force-pushed on Nov 6, 2014
  6. randy-waterhouse commented at 1:48 AM on November 6, 2014: contributor

    #5195 should be fixed (AM_INIT_AUTOMAKE doesn't check for gcc) but if @paveljanik could test on his platform (SLES12, gcc added (no g++)) to make sure.

    Also I have now removed those unusued or redundant AC_PROG_\ as you suggest, thanks.

  7. theuni commented at 2:12 AM on November 6, 2014: member

    looks good, assuming @paveljanik can confirm. Thanks.

  8. paveljanik commented at 6:33 AM on November 6, 2014: contributor

    No problem, I'll do so later today.

  9. paveljanik commented at 12:04 PM on November 6, 2014: contributor

    OK, I tested this:

    • clean SUSE12 install, SDK added (no RPMs installed from it yet)
    • checkout randy-waterhouse:config
    • ./autogen.sh
    • ./configure configure: error: C++ compiler cannot create executables GOOD
    • zypper -n in gcc-c++
    • ./configure checking for Berkeley DB C++ headers... no configure: error: libdb_cxx headers missing GOOD
    • zypper -n in libdb-4_8-devel
    • ./configure ... checking for dynamic linked boost test... no configure: error: No working boost sleep implementation found. GOOD (could be better, later...)
    • zypper -n in boost-devel
    • ./configure checking for SSL... no configure: error: openssl not found. GOOD
    • zypper -n in openssl-devel
    • ./configure OK
    • make OK

    To sum this: OK.

    When building on minimal installation of SLES12, the needed RPM packages are:

    gcc-c++ boost-devel libdb-4_8-devel openssl-devel

    and are correctly reported by configure. Thanks!

  10. laanwj commented at 12:12 PM on November 6, 2014: member

    Thanks for checking @paveljanik

  11. laanwj merged this on Nov 6, 2014
  12. laanwj closed this on Nov 6, 2014

  13. laanwj referenced this in commit 2262415411 on Nov 6, 2014
  14. randy-waterhouse deleted the branch on Nov 6, 2014
  15. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-28 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me