Qt: add min size for input field in askpassphrase dialog #5226

Because of unexpected long i18n strings the input fields end up with a tiny hight of about 5 px. Setting a min height on the input fields solves the problem for me.

example of how the situation looks without this change (OSX 10.10 / qt5):

After this change:

Instead of hardcoding 20 pixels it would be nice to get a suggested height for input widgets. Qt has various sizing settings (both on layout and widget level), are you sure it's not solvable with those alone?

I tried different approaches but didn't succeed with setting constraints. Somehow the problem is that the QDialog should have a flexible height but as far as i see the QFormLayout does not stretch in height. And my QT knowhow is very limited.

Maybe this solution is not the best but better then the current state (unusable password entry dialog).

It would be great if someone could review/test this because i think it would be good t have this in 0.10. Currently entering wallet encryption passphrase in OSX looks really bad.

@jonasschnelli well I can merge it if it is an improvement, but I don't like absolute pixel sizes at all; people will have different font sizes, especially for accessibility reasons. This reeks of "this fixes it in my specific setup so it should be OK". The window indeed behaves strangely (at least in Qt5). It's also resizable. Going to look into this.

I isolated the root cause in askpassphrasedialog.cpp:

ui->warningLabel->setText(tr("Enter the new passphrase to the wallet.<br/>Please use a passphrase of <b>ten or more random characters</b>, or <b>eight or more words</b>."));

Commenting these out causes the window to behave normally. So maybe somehow Qt needs to be kicked after this to enforce sizing constraints again.

Hm. The problem is that the QLabel grows in size, and the rest of the layout doesn't cope with that in the correct way.

See #5320 for an attempt at a fix without hardcoding any values... it's still ugly, but I wasn't able to solve it just with changing policies.

superseded by #5320, closing.