Rename "dir" to "dirname" because "dir" is the name of a function in python, and it is a generally good idea to not override existing functions, even if dir is unlikely to be used.
Rename dir to dirname in qa/rpc-tests/util.py #5282
pull kanzure wants to merge 1 commits into bitcoin:master from kanzure:dont-override-dir-in-qa-rpc-tests changing 1 files +8 −8-
kanzure commented at 3:20 PM on November 14, 2014: contributor
-
a7af9839d6
don't override dir() in qa rpc tests
Replace "dir" with "dirname" in util.py in qa/rpc-tests/ because "dir" is the name of a function in python.
-
gavinandresen commented at 6:53 PM on November 14, 2014: contributor
ACK.
Thinking out loud: it would be super spiffy if changes to our .py files were automagically run through one or more of the python lint tools as part of the Travis pull-testing process.....
-
theuni commented at 9:31 PM on November 14, 2014: member
@gavinandresen That does sound nice. Do you happen to know of any tools that will do linting at runtime? With all the JIT work these days, I'd think there would be something to handle it in one step, so that we could get error-checking as a side-effect of running as usual.
-
kanzure commented at 9:52 PM on November 14, 2014: contributor
Here are some okay linters:
-
laanwj commented at 10:21 AM on November 17, 2014: member
Does travis have a way to display warnings? I wouldn't want all the tests to fail because of a false positive in some linter. My experience is that they're quite false-positive-heavy.
-
laanwj commented at 10:24 AM on November 17, 2014: member
ACK commithash a7af9839d688bee9b0b15add61259140b3c00014 https://dev.visucore.com/bitcoin/acks/5282
- laanwj merged this on Nov 17, 2014
- laanwj closed this on Nov 17, 2014
- laanwj referenced this in commit 09481eec88 on Nov 17, 2014
-
- MarcoFalke locked this on Sep 8, 2021
Contributors