travis: Update .travis.yml to remove mac sdk preparation on non-mac platforms. #5294

pull imharrywu wants to merge 1 commits into bitcoin:master from imharrywu:patch-4 changing 1 files +3 −3

imharrywu commented at 7:36 AM on November 17, 2014: contributor

it seems no need to prepare mac sdk for non-mac platforms.
laanwj commented at 7:53 AM on November 17, 2014: member

Please use a commit message that details the change, instead of just "Update .travis.yml"
imharrywu renamed this:
~~Update .travis.yml~~
travis: Update .travis.yml to remove mac sdk preparation on non-mac platforms.
on Nov 17, 2014
laanwj commented at 9:52 AM on November 17, 2014: member

You haven't updated the commit message, just the issue title, although that's also useful
travis: Update .travis.yml to remove mac sdk preparation on non-mac platforms. 36137d6e38
theuni commented at 6:22 PM on November 17, 2014: member

What problem does this solve? The osx host won't always be "x86_64-apple-darwin11", and OSX_SDK is only set for osx builds.
imharrywu commented at 1:12 AM on November 18, 2014: contributor

thanks for remind, this pull request is a mistake, i have not noticed that OS_SDK var check. please reject and close it. thanks.
theuni commented at 1:18 AM on November 18, 2014: member

@imharrywu No problem, thanks for having a look!
sipa closed this on Nov 18, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors