[Qt, OSX] fix usage of osx 10.8+ user notification center #5300

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:10.8+_not_center changing 1 files +23 −1

jonasschnelli commented at 9:58 AM on November 18, 2014: contributor

Currently Bitcoin-Qts support for OSX User Notification Center is broken. This pull will fix a known issue of non-official-apple-built apps having problems sending user notifications.

Again this is a unloved platform dependent thing but we might continue to support this because we started this in #2615.

[Qt, OSX] fix usage of osx 10.8+ user notification center

Currently Bitcoin-Qts support for OSX User Notification Center is broken. This pull will fix a known issue of non-official-apple-built apps having problems sending user notifications.

a7f2941068

in src/qt/macnotificationhandler.mm:None in 8626a9745f outdated

   4 | @@ -5,8 +5,21 @@
   5 |  #include "macnotificationhandler.h"
   6 |  
   7 |  #undef slots
   8 | +#import <objc/runtime.h>
   9 |  #include <Cocoa/Cocoa.h>
  10 |  
  11 | +// add a obj-c categorie (extension) to return the expected bundle ifentifier

Diapolo commented at 12:14 PM on November 18, 2014:

Nit: Spelling Add an obj-c category (extension) to return the expected bundle identifier

jonasschnelli commented at 12:43 PM on November 18, 2014:

Thanks!

in src/qt/macnotificationhandler.mm:None in 8626a9745f outdated

   4 | @@ -5,8 +5,21 @@
   5 |  #include "macnotificationhandler.h"
   6 |  
   7 |  #undef slots
   8 | +#import <objc/runtime.h>
   9 |  #include <Cocoa/Cocoa.h>
  10 |  
  11 | +// add a obj-c categorie (extension) to return the expected bundle ifentifier
  12 | +@implementation NSBundle(returnCorrectIdentifier)
  13 | +- (NSString *)__bundleIdentifier

Diapolo commented at 12:15 PM on November 18, 2014:

This could use also 4 space indentation I guess?

jonasschnelli commented at 12:44 PM on November 18, 2014:

the @implementationblock normally is not indented.

Diapolo commented at 12:45 PM on November 18, 2014:

Fine then :).

in src/qt/macnotificationhandler.mm:None in 8626a9745f outdated

  80 | +    if (!s_instance) {
  81 |          s_instance = new MacNotificationHandler();
  82 | +        
  83 | +        Class aPossibleClass = objc_getClass("NSBundle");
  84 | +        if (aPossibleClass) {
  85 | +            // change NSBundle -bundleIdentifier methode to return a correct bundle indentifier

Diapolo commented at 12:16 PM on November 18, 2014:

Nit: Spelling method and at the end identifier :).

jonasschnelli commented at 12:44 PM on November 18, 2014:

Thanks! Fixed.

jonasschnelli force-pushed on Nov 18, 2014
laanwj commented at 1:28 PM on November 18, 2014: member

Again this is a unloved platform dependent thing but we might continue to support this because we started this in #2615.

Well this is completely contained to an already platform-specific file, that's fine.

utACK commithash a7f29410681b367620c780453b0abb9688831766 https://dev.visucore.com/bitcoin/acks/5300
laanwj added the label GUI on Nov 18, 2014
laanwj added the label Mac on Nov 18, 2014
laanwj merged this on Nov 19, 2014
laanwj closed this on Nov 19, 2014
laanwj referenced this in commit 5716808ca7 on Nov 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#2615 osx: make use of the 10.8+ user notification center to display growl lik...