[Qt] small changes to sendcoinsdialog #5323

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_fee changing 1 files +10 −6

Diapolo commented at 12:08 PM on November 20, 2014: none
- add newly added variables to the constructor init
- move an already existing bool also to constructor init
- move a connect call to setClientModel and add a NULL pointer check
in src/qt/sendcoinsdialog.cpp:None in b9e1b6b0c8 outdated
```
 119 | @@ -119,7 +120,8 @@ void SendCoinsDialog::setModel(WalletModel *model)
 120 |  {
 121 |      this->model = model;
 122 |  
 123 | -    if(model && model->getOptionsModel())
 124 | +    // setClientModel() is called before setModel(), see WalletFrame::addWallet()
```
laanwj commented at 1:21 PM on November 24, 2014:

The order in which the setXXXmodel get called ideally shouldn't matter. Why do we use the client model here?

Diapolo commented at 3:54 PM on November 25, 2014:

It was added by @cozz and is used in this line: connect(clientModel, SIGNAL(numBlocksChanged(int)), this, SLOT(updateSmartFeeLabel()));

That comment can perhaps just be removed... I just found it good to know that in that setModel() call we can be sure that setClientModel() was called (in current code).

Diapolo commented at 3:55 PM on November 25, 2014:

Well perhaps that signal should be connected in setClientModel ;)... makes more sense and removes the comment ^^.

[Qt] small changes to sendcoinsdialog

- add newly added variables to the constructor init
- move an already existing bool also to constructor init
- move a connect call to setClientModel and add a NULL pointer check

a328dd60a7

laanwj merged this on Nov 26, 2014
laanwj closed this on Nov 26, 2014
laanwj referenced this in commit 4baa9f0c9b on Nov 26, 2014
Diapolo deleted the branch on Nov 26, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Diapolo

laanwj