build: fix link error on some platforms. Fixes #5235 #5332

pull theuni wants to merge 1 commits into bitcoin:master from theuni:libbitcoinconsensus2 changing 1 files +1 −1
  1. theuni commented at 6:41 PM on November 20, 2014: member

    Some users may have libtool libs (.la) installed in their linker search paths. In this case, using -static-libtool-libs would try to link in .a's instead of shared libs. That would be harmless unless the .a was built in a way that would break linking, like non-fpic.

    What we really want is "-static" here. Despite its name, it's actually less aggressive than -static-libtool-libs. It causes only internal libs to be linked statically (libbitcoinconsensus is the one were'a after).

  2. theuni commented at 6:42 PM on November 20, 2014: member

    Grr, that should've been: fixes #5331

  3. build: fix link error on some platforms. Fixes #5235
    Some users may have libtool libs (.la) installed in their linker search paths.
    In this case, using -static-libtool-libs would try to link in .a's instead of
    shared libs. That would be harmless unless the .a was built in a way that
    would break linking, like non-fpic.
    
    What we really want is "-static" here. Despite its name, it's actually less
    aggressive than -static-libtool-libs. It causes only internal libs to be linked
    statically (libbitcoinconsensus is the one were'a after).
    f618577029
  4. laanwj merged this on Nov 21, 2014
  5. laanwj closed this on Nov 21, 2014

  6. laanwj referenced this in commit 216685a6df on Nov 21, 2014
  7. DrahtBot locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me