[Qt, OSX] fix Qt4.8 compatibility with QProgressBar issue #5344

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:QProgressBarBugQt5 changing 1 files +1 −1
  1. jonasschnelli commented at 7:07 pm on November 21, 2014: contributor
  2. [Qt, OSX] fix Qt4.8 compatibility with QProgressBar issue 7f33d2cebf
  3. Diapolo commented at 11:14 pm on November 21, 2014: none
    Should the check be >=?
  4. theuni commented at 11:33 pm on November 21, 2014: member
    Could you elaborate on what the actual compatibility issue is here, please? The commit message/pull description aren’t really helpful.
  5. theuni commented at 11:49 pm on November 21, 2014: member
    Nm, I see it now over at #5296. Would be helpful if you could reference the previous discussion in follow-ups like this.
  6. jonasschnelli commented at 7:01 am on November 22, 2014: contributor
    Yes. Sorry. I forgot to reference #5296. The problem is, that the enum used in the pull 5296 is only available in qt5.
  7. laanwj commented at 8:40 am on November 24, 2014: member

    Should the check be >=?

    I think so too. Would be more consistent. Although I doubt there is any version that advertises QT_VERSION==0x050000.

  8. laanwj added the label GUI on Nov 24, 2014
  9. laanwj added this to the milestone 0.10.0 on Nov 24, 2014
  10. laanwj referenced this in commit c5a2282855 on Nov 24, 2014
  11. laanwj commented at 2:28 pm on November 24, 2014: member
    Merged via c5a22828559bdac8fd347e30a3027dbaf54934ae
  12. laanwj closed this on Nov 24, 2014

  13. jameshilliard referenced this in commit 40b7c71318 on Apr 15, 2015
  14. reddink referenced this in commit 9719370125 on May 27, 2020
  15. MarcoFalke locked this on Sep 8, 2021


jonasschnelli Diapolo theuni laanwj

Labels
GUI

Milestone
0.10.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me