No description provided.
[Qt, OSX] fix Qt4.8 compatibility with QProgressBar issue #5344
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:QProgressBarBugQt5 changing 1 files +1 −1-
jonasschnelli commented at 7:07 PM on November 21, 2014: contributor
-
[Qt, OSX] fix Qt4.8 compatibility with QProgressBar issue 7f33d2cebf
-
Diapolo commented at 11:14 PM on November 21, 2014: none
Should the check be
>=? -
theuni commented at 11:33 PM on November 21, 2014: member
Could you elaborate on what the actual compatibility issue is here, please? The commit message/pull description aren't really helpful.
-
jonasschnelli commented at 7:01 AM on November 22, 2014: contributor
Yes. Sorry. I forgot to reference #5296. The problem is, that the enum used in the pull 5296 is only available in qt5.
-
laanwj commented at 8:40 AM on November 24, 2014: member
Should the check be >=?
I think so too. Would be more consistent. Although I doubt there is any version that advertises
QT_VERSION==0x050000. - laanwj added the label GUI on Nov 24, 2014
- laanwj added this to the milestone 0.10.0 on Nov 24, 2014
- laanwj referenced this in commit c5a2282855 on Nov 24, 2014
-
laanwj commented at 2:28 PM on November 24, 2014: member
Merged via c5a22828559bdac8fd347e30a3027dbaf54934ae
- laanwj closed this on Nov 24, 2014
- jameshilliard referenced this in commit 40b7c71318 on Apr 15, 2015
- reddink referenced this in commit 9719370125 on May 27, 2020
- MarcoFalke locked this on Sep 8, 2021