qt: osx: fix hidden symbol visibility #5362

pull theuni wants to merge 1 commits into bitcoin:master from theuni:osx-symbol-visibility changing 1 files +1 −0
  1. theuni commented at 2:57 AM on November 25, 2014: member

    Fixes default hidden symbol visibility for our linux->osx cross build. Without this change, the check for working -fvisibility=hidden fails, and all symbols are visible by default.

    Because the darwin linker doesn't have an option like exclude-libs=all, this visibility is actually significant. It also cleans up hundreds of lines of debug spew about conflicting visibility at link-time.

    Ugly as this is, it's just a simple find/replace to fix a bug in Qt's configure. They assume in an "XPLATFORM_MAC" block that the builder is capable of running osx programs. This should be "BUILD_ON_MAC" instead.

  2. qt: osx: fix hidden symbol visibility
    Fixes default hidden symbol visibility for our linux->osx cross build. Without
    this change, the check for working -fvisibility=hidden fails, and all symbols
    are visible by default.
    
    Ugly as this is, it's just a simple find/replace to fix a bug in Qt's configure.
    They assume in an "XPLATFORM_MAC" block that the builder is capable of running
    osx programs. This should be "BUILD_ON_MAC" instead.
    d61dc25c71
  3. theuni commented at 3:40 AM on November 25, 2014: member

    s/hundreds/~dozen/. I suppose I was thinking of the boost visibility change that caused hundreds of warnings. These aren't so bad, but still should be addressed.

    before: https://travis-ci.org/bitcoin/bitcoin/jobs/42002983#L1555 after: https://travis-ci.org/bitcoin/bitcoin/jobs/42036711#L7265

  4. laanwj merged this on Nov 25, 2014
  5. laanwj closed this on Nov 25, 2014

  6. laanwj referenced this in commit 97bef1203d on Nov 25, 2014
  7. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me