Handling of MSG_NOSIGNAL is spread over several source files.
It should be handled in compat.h (defined if not defined on the system) and then used in src/net.cpp, src/netbase.cpp. Right now, the ifdef code is in all files.
Low prio, I'll take care about this issue.
I'm OK with this being cleaned up, but why is this an issue? It isn't broken due to this.
@laanwj well, it was the (indirect) cause of other bug we have solved this week. Thus I filled it to fix it later. BTW - how do I assign the bug, how do I add Priority Low label? I do not think the interface allows me to do it.
It's not really meant as a personal TODO list. Although I've been guilty of that too at times. I've added your low priority label.
My first idea was to remove the testing from configure completely and use simple
#ifndef MSG_NOSIGNAL
#define MSG_NOSIGNAL 0
#endif
in compat.h (and only there) but we can't use it, because on some systems, MSG_NOSIGNAL can be enum, global constant or whatever... Some projects use this simple tests, but it can only bring problems.
Boost is using completely different approach:
#if defined(__linux__)
flags |= MSG_NOSIGNAL;
#endif // defined(__linux__)
It is not worth the effort. Closing.