[REST] make selection of output-format mandatory, support dot url syntax #5376

1. 
   jonasschnelli commented at 1:24 pm on November 26, 2014: contributor

   1. Remove the default format (binary) because rest/block/<hash>/Hex would end up delivering binary data.
   2. List available formats when chosen format was not found (reduces need for documentation)
   3. Change url syntax to extension like format chosing (like rest/tx/<hash>.json (as originally mentioned in #2844)
2. jonasschnelli force-pushed on Nov 26, 2014
3. laanwj added this to the milestone 0.10.0 on Nov 27, 2014
4. 
   sipa commented at 10:30 am on November 27, 2014: member

   Concept ACK, but I wouldn’t do the case insensitivity. That just means more combinations to support in the future.

   Also, coding style (spaces after if etc).

5. 
   laanwj commented at 10:58 am on November 27, 2014: member

   Agree with sipa. Please don’t leave any wiggling room in the REST API. Aliasing is generally bad, for example with regard to webcaches and such. One URL should map to one query.
6. jonasschnelli force-pushed on Nov 27, 2014
7. 
   jonasschnelli commented at 12:17 pm on November 27, 2014: contributor

   Agreed. It was a stupid idea to support uppercase/mixed-case URIs. Just removed the toLowercase transition. I also fixed the coding style (nit me if i didn’t do it proper).
8. 
   laanwj commented at 12:21 pm on November 27, 2014: member

   utACK
9. jonasschnelli force-pushed on Nov 27, 2014
10. jonasschnelli force-pushed on Nov 27, 2014
11. 
    jonasschnelli commented at 1:05 pm on November 27, 2014: contributor

    Update coding style by auto.-reformatting with the src/.clang-format file. Tell me if there are still uncommon formatting.
12. jonasschnelli force-pushed on Nov 27, 2014
13. 
    laanwj commented at 1:06 pm on November 27, 2014: member

    Looks good to me now.
14. [REST] make selection of output-format mandatory, support dot url syntax

    1. Remove the default format (binary) because `rest/block/<hash>/Hex` would end up delivering binary data.
    2. List available formats when chosen format was not found (reduces need for documentation)
    3. Change url syntax to dot extension like format chosing (like `rest/tx/<hash>.json`

    8a5c9513ba
15. jonasschnelli force-pushed on Nov 27, 2014
16. 
    jgarzik commented at 1:11 pm on November 27, 2014: contributor

    Looks good, will test
17. laanwj added the label RPC on Nov 28, 2014
18. 
    sipa commented at 3:03 pm on November 28, 2014: member

    Slightly tested ACK
19. laanwj merged this on Dec 2, 2014
20. laanwj closed this on Dec 2, 2014

    ---

21. laanwj referenced this in commit fec0d100d5 on Dec 2, 2014
22. laanwj referenced this in commit 90f7aa7778 on Dec 2, 2014
23. reddink referenced this in commit 527b113237 on May 27, 2020
24. MarcoFalke locked this on Sep 8, 2021

Contributors
jonasschnelli sipa laanwj jgarzik

Labels
RPC/REST/ZMQ

Milestone
0.10.0