Before 0.10 release cleanup source with clang-style-script #5377

I've been told that is the right thing to do and would like to remind for it :).

@Diapolo: so you mean automatically reformat all .cpp source files?

@jonasschnelli The plan has been for a while to apply clang-format to the whole source tree before the 0.10 release.

If help is wished I could create a patch or supply a script.

I know others have other opinions (I've mentions this some months ago): I still like libcurls (cURL) way of blocking wrong code style by including a code-formatting check into the make check process.

It's more of a matter of when.

Most of the big changes for 0.10 have gone in, apart from Deterministic Signing mostly small stuff left in https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.10.0 .

So if we're going to do this, I think now would be a good time as any.

NACK on including a code-formatting check in the make check process and/or travis tests. Tests should check only correctness. I don't want people to bogged down in silly bureaucracy (and have to install Yet Another Tool) before they can propose changes. If we want to be compulsive about this we could do it while merging I suppose...

See #5387.

Ping, what's up with this?

Close this?

Or rebase #5387?

There needs something to be done, I don't and never will be understanding, why this can be such a problem...

@Diapolo: Pleas read #5387 (comment). No need to post such comments.