Probably fixes #5346 I did not test anything, but seems pretty obvious that we are calling wallet->GetAccountAddresses(..) without a lock here.
[Qt] Fix wallet-lock in PaymentServer::fetchPaymentACK(..) #5390
pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz5 changing 1 files +1 −1-
cozz commented at 6:42 PM on November 28, 2014: contributor
-
laanwj commented at 6:03 AM on November 29, 2014: member
Alternatively, we could change the assertlockheld(cs_wallet) in
GetAccountAddressesto LOCK(cs_wallet). Note that SetAddressBook takes care of its own locking already, so it would be more consistent. -
[Qt] Fix wallet-lock in CWallet::GetAccountAddresses(..) 43422a0121
- cozz force-pushed on Nov 29, 2014
-
- laanwj merged this on Dec 1, 2014
- laanwj closed this on Dec 1, 2014
- laanwj referenced this in commit 89151d9f29 on Dec 1, 2014
- IeuanG referenced this in commit 71c6a90c95 on Feb 2, 2015
- MarcoFalke locked this on Sep 8, 2021
