We have the same check a few/five lines above this line, in the section "Size limits" and such block is already bad-blk-length. Looks like bad merge or something.
Do not check twice for empty set of transactions. #5396
pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:doubleemptycheck changing 1 files +1 −1-
paveljanik commented at 9:28 PM on November 30, 2014: contributor
-
Do not check twice for empty set of transactions. e9622acba7
-
sipa commented at 9:32 PM on November 30, 2014: member
untested ACK
-
laanwj commented at 9:11 AM on December 1, 2014: member
I like keeping this check here. This is critical code and there it is better to be explicit, which could save the day in case checks get reordered.
- laanwj closed this on Dec 1, 2014
-
paveljanik commented at 11:13 AM on December 1, 2014: contributor
OK, np. The code is a bit unreadable this way without comment above this check saying so...
- paveljanik deleted the branch on Dec 2, 2014
- MarcoFalke locked this on Sep 8, 2021
Contributors