Usage of CheckProofOfWork for block generation #5405

issue ghost opened this issue on December 2, 2014

ghost commented at 3:00 PM on December 2, 2014: none

The recent (expansion of) usage of CheckProofOfWork (pow.cpp +78) for block generation (#5275, rpcmining.cpp +181) needs an adjustment to its error output/conditions. As it stands now, every occurrence of a nonce that results in an insufficient hash is LogPrint-ed: as "CheckProofOfWork() : hash doesn't match nBits", a valuable insight when validating proof of work, but not so much when generating it.
gavinandresen added the label Tests on Dec 2, 2014
gavinandresen added the label Priority Low on Dec 2, 2014
ghost commented at 1:12 AM on February 2, 2015: none

Update: #4793 reduces the (error) probability, but not to 0.
MarcoFalke added the label Mining on Sep 27, 2016
MarcoFalke removed the label Tests on Sep 27, 2016
MarcoFalke added the label Tests on Sep 27, 2016
MarcoFalke commented at 7:33 PM on September 27, 2016: member

@21E14 Is this still an issue?
laanwj commented at 8:21 AM on September 28, 2016: member

CheckProofOfWork doesn't log that message anymore since #7962, a pull by the same author as this PR. So yes we can close this.

Edit: that was just a cleanup, #7459 did the work of removing the printfs.
laanwj closed this on Sep 28, 2016
ghost commented at 10:53 PM on October 8, 2016: none

@MarcoFalke @laanwj ACK.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels