The code to calculate these seems to be entirely disconnected from the code actually used for mining transaction selection, and appears to produce different values. This should either be documented, removed, or changed to be the same IMO.
getrawmempool {starting,current}priority are unrelated to actual tx priority? #5412
issue luke-jr opened this issue on December 3, 2014-
luke-jr commented at 7:39 AM on December 3, 2014: member
-
bitcoinfees commented at 8:09 AM on December 3, 2014: none
Yes I recently realized this as well. Currently it gives an upper bound for the actual priority, with equality iff all inputs were in the blockchain at the time of entry to mempool (assuming no reorgs).
Also in the priority initialization in AcceptToMemoryPool, I believe the second argument should be
chainActive.Height() + 1instead of simplychainActive.Height() - laanwj added the label RPC on Dec 5, 2014
-
achow101 commented at 12:20 AM on June 13, 2017: member
This should be closed as priority (at least the output in getrawmempool) has been removed in https://github.com/bitcoin/bitcoin/commit/49be7e1bef23afec617ed211a804f375f1620a22
- sipa closed this on Jun 13, 2017
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels