Update libsecp256k1 #5439

pull sipa wants to merge 3 commits into bitcoin:master from sipa:secp changing 23 files +706 −700

sipa commented at 2:12 PM on December 7, 2014: member
Import some patches from libsecp256k1. Highlights:
- Use GCC inline assembly instead of YASM (lower dependencies, faster)
- Do large precomputations on the heap (to avoid stack overflows).
- Check results of malloc.

Squashed 'src/secp256k1/' changes from b0210a9..3545627

3545627 Merge pull request #118
6a9901e Merge pull request #137
376b28b Merge pull request #128
1728806 Merge pull request #138
a5759c5 Check return value of malloc
39bd94d Variable time normalize
ad86bdf Merge pull request #140
54b768c Another redundant secp256k1_fe_normalize
69dcaab Merge pull request #139
1c29f2e Remove redundant secp256k1_fe_normalize from secp256k1_gej_add_ge_var.
2b9388b Remove unused secp256k1_fe_inv_all
f461b76 Allocate precomputation arrays on the heap
b2c9681 Make {mul,sqr}_inner use the same argument order as {mul,sqr}
6793505 Convert YASM code into inline assembly
f048615 Rewrite field assembly to match the C version
3ce74b1 Tweak precomputed table size for G

git-subtree-dir: src/secp256k1
git-subtree-split: 3545627acb6059832834569829e97fb469933b29

4903b80d6a

Update libsecp256k1 6d1980f02e

sipa commented at 2:46 PM on December 7, 2014: member

I can't reproduce this.

Tried:

./configure --prefix=/home/pw/git/bitcoin/depends/x86_64-unknown-linux-gnu/ --enable-glibc-back-compat
make check

All works fine, and:

valgrind ./src/bitcoin-tx - <src/test/data/blanktx.hex

(the test which segfaults in Travis) also gives 0 errors.

sipa force-pushed on Dec 8, 2014
sipa force-pushed on Dec 8, 2014
sipa force-pushed on Dec 8, 2014
sipa force-pushed on Dec 8, 2014
Upload result 7df6c17a94
sipa force-pushed on Dec 8, 2014
sipa commented at 4:30 PM on December 8, 2014: member

Closing until bug fixed in secp256k1 repo.
sipa closed this on Dec 8, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

sipa