Innocuous change in wallet. Move CoinSet typedef from wallet_tests.cpp to wallet.h and use it there and in wallet.cpp.
Wallet: Use typedef CoinSet in wallet.o #5446
pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:coinset changing 3 files +7 −7-
jtimon commented at 2:08 PM on December 8, 2014: contributor
-
Use typedef CoinSet in wallet.o 54f7fe5454
-
gavinandresen commented at 3:18 PM on December 8, 2014: contributor
I don't like these type of tidy-up changes; our bottleneck is review and testing, and this just adds to our review and testing overhead with almost no benefit.
And personally, I prefer to see the explicit type for trivial types like this; the added indirection of a typedef isn't worth it for me.
- jtimon closed this on Dec 9, 2014
-
laanwj commented at 7:03 AM on December 10, 2014: member
Neutral on this. A typedef is useful to make it possible to change the underlying implementation. Eg we did this for
CCoinsMap, to easily be able to switch between std::map, boost::unordered_map, etc.My comment would be on the name
CCoinsSet- it is way too aspecific for a wallet-specific type and clashes withCCoinsMapin that way.Anyhow, as said, I'm neutral on this, I don't think it makes much difference whether to to it for a type like this that is only used in one or two places and we'll likely never change.
- MarcoFalke locked this on Sep 8, 2021
Contributors