minor rework of SendMoney in rpcwallet #5452

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:sendmoney changing 1 files +12 −17

Diapolo commented at 1:56 PM on December 9, 2014: none
- rework the function to not log errors but use throw JSONRPCError
- remove a check for IsLocked() that is done in sendtoaddress and sendfrom RPC calls already
- cache GetBalance() return value, because it's possibly used twice
Intended for discussion, also I was thinking about extending our wallet error codes, as most errors in SendMoney use the generic RPC_WALLET_ERROR.
paveljanik commented at 2:16 PM on December 9, 2014: contributor

Looks like this is a duplicate to #5399?
Diapolo renamed this:
~~move and rework SendMoney to rpcwallet~~
minor rework of SendMoney in rpcwallet
on Dec 10, 2014
Diapolo commented at 10:32 AM on December 10, 2014: none

@laanwj Rebased and open for discussion (extend wallet error codes).
laanwj commented at 10:09 AM on December 12, 2014: member

I don't see it because you do so many unrelated changes. Does this improve anything or does it just fudge around the code?

minor rework of SendMoney in rpcwallet

- rework the function to not log errors but use throw JSONRPCError
- remove a check for IsLocked() that is done in sendtoaddress and
  sendfrom RPC calls already
- cache GetBalance() return value, because it's possibly used twice

73f7ee8930

very minor include ordering cleanup for rpcwallet.cpp 022887909d
Diapolo commented at 1:16 PM on December 16, 2014: none

@laanwj Yes, it improves what is mentioned in the pull-description. Also I choose to add the cleanup as second pull... if you whis, you may aswell just look at the first commit.
jgarzik commented at 12:47 PM on December 31, 2014: contributor

Let's leave it as is for now. Revisit once dust settles from other changes.
jgarzik closed this on Dec 31, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors