signrawtransaction crashes bitcoind when given the zero private key #5454

bitcoind signrawtransaction $(bitcoind createrawtransaction '[{"txid":"deadbeef","vout":1}]' '{}') '[]' '["5HpHagT65TZzG1PH3CSu63k8DbpvD8s5ip4nEB3kEsreAbuatmU"]'
error: no response from server

A fix appears to be to insert:

        if (!key.IsValid()) {
            throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid private key");
        }

before:

        tempKeystore.AddKey(key);

in src/rpcrawtransaction.cpp

But maybe the

        bool fGood = vchSecret.SetString(k.get_str());

a few lines above shouldn't have fGood be true for the zero private key?

I can reproduce in the current master.

Assertion failed: (fValid), function GetPubKey, file key.cpp, line 65.

The check for a private key in the valid range is missing (like in importprivkey):

if (!key.IsValid()) throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Private key outside allowed range");

The fix is now merged to the master. Closing. Thank you for the report!

@dooglus Ping, you can close this now :).