verifychain & "BIP 30" duplicate transactions in the chain #5498

issue Diapolo opened this issue on December 17, 2014
  1. Diapolo commented at 9:02 AM on December 17, 2014: none

    Just reposting from https://bitcointalk.org/index.php?topic=895501.0 so it get's attention.

    Does Bitcoin Core's "verifychain" in level=3 accept the duplicate transaction ID's in the chain (those that fail strict BIP30 checks, as listed in main.cpp in ConnectBlock)? I have the feeling that the strict check done in DisconnectBlock (that the tx outputs currently being undone match between what's in the block and what's in the coin view) could fail for those. Unfortunately, I'm not able to check this "live" as it would require way too much memory. I. e., while checking, the coins cache is filled and then level=3 checks are skipped for deeper blocks.

    If my suspicion is right, is this simply not "fixed" because it does not matter, or is there some other reason? (One could, for instance, move the list of BIP30-failing hashes to the chain parameters and use it both for fEnforceBIP30 as well as ignoring those DisconnectBlock failures.) If, on the other hand, this is not a "problem" and DisconnectBlock works for those, why?

  2. Diapolo closed this on Oct 31, 2015

  3. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me