Reduce boost namespace pollution #5513

pull theuni wants to merge 3 commits into bitcoin:master from theuni:namespace changing 20 files +90 −128

theuni commented at 9:51 PM on December 19, 2014: member

Should fix #3483, as well as being a good practice in general. The second commit changes a bit of code, so it's not lumped in with the rest. The others should be semantic changes only.

After this, there are only 2 users of "using namespace boost::foo" left, and those were left in because they're very wordy otherwise.
zander commented at 9:16 AM on December 29, 2014: none

I really like the first and the last commit, they look good to me. I personally would reject the middle commit that touches the unit test (see comment there).
jonasschnelli commented at 10:15 AM on December 29, 2014: contributor

IMO: this makes the code more readable and i also see this as a good practice. ACK (reviewed, compiled, make check).
laanwj commented at 4:40 PM on January 2, 2015: member

Looks good to me. I'm not a big fan of 'using namespace XXX' on a global level either. If it makes things too wordy you can always use them at a function level.

Needs rebase though.
laanwj added the label Improvement on Jan 2, 2015
theuni force-pushed on Jan 2, 2015
theuni commented at 8:10 PM on January 2, 2015: member

rebased
namespace: remove boost namespace pollution a3241998e1
namespace: drop boost::assign altogether here
Standard functions are even simpler
9b1ab860ff
namespace: drop most boost namespaces and a few header cleanups
A few boost::asio were left around because they're very wordy otherwise.
856e862f4a
sipa commented at 4:01 PM on January 4, 2015: member

Untested ACK. @zander Your comment on the second commit is lost due to the rebase.
theuni commented at 7:13 PM on January 5, 2015: member

Pre-rebase comments can be seen here: https://github.com/theuni/bitcoin/commit/705292e4086782dd7a72547f85d78910c884d393#commitcomment-9105866

laanwj commented at 7:15 PM on January 6, 2015: member

ACK, no binary changes in bitcoind

230b275c285433955d58623a3d388f7b89839003c359773876932a5cb7686a5e  bitcoind.856e862.stripped
230b275c285433955d58623a3d388f7b89839003c359773876932a5cb7686a5e  bitcoind.f55c5e9.stripped

laanwj merged this on Jan 6, 2015
laanwj closed this on Jan 6, 2015
laanwj referenced this in commit 729ba31749 on Jan 6, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#3483 boost, reference to ‘int64_t’ is ambiguous