internal RPC/REST http server has no timeout-implementation #5526

issue jonasschnelli openend this issue on December 22, 2014
  1. jonasschnelli commented at 2:05 pm on December 22, 2014: contributor

    There is no connection timeout for the internal http server (REST/RPC). Malfunction clients could produce zombi-idling rpc threads. I had a look at it and there would be need to change the current implementation to do it async (something like boost::asio async). Currently it’s a getline() on the raw stream.

    A good starting point could be: http://www.boost.org/doc/libs/1_45_0/doc/html/boost_asio/example/timeouts/async_tcp_client.cpp

  2. jgarzik commented at 2:07 pm on December 22, 2014: contributor
    This is a better starting point: https://github.com/jgarzik/rpcsrv :)
  3. luke-jr commented at 11:23 am on January 1, 2015: member
    Malfunctioning clients? There’s nothing wrong with clients keeping a connection open to keep-alive HTTP servers…
  4. kanzure commented at 3:32 pm on September 4, 2015: contributor
    Could be closed now that #5677 is merged? see #5677 (comment) @jonasschnelli @laanwj
  5. paveljanik commented at 7:47 pm on October 1, 2015: contributor
    ping :-)
  6. jonasschnelli commented at 7:47 pm on October 1, 2015: contributor
    Solved with #5677, closing.
  7. jonasschnelli closed this on Oct 1, 2015

  8. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me