internal RPC/REST http server has no timeout-implementation #5526

issue jonasschnelli opened this issue on December 22, 2014

jonasschnelli commented at 2:05 PM on December 22, 2014: contributor

There is no connection timeout for the internal http server (REST/RPC). Malfunction clients could produce zombi-idling rpc threads. I had a look at it and there would be need to change the current implementation to do it async (something like boost::asio async). Currently it's a getline() on the raw stream.

A good starting point could be: http://www.boost.org/doc/libs/1_45_0/doc/html/boost_asio/example/timeouts/async_tcp_client.cpp
jgarzik commented at 2:07 PM on December 22, 2014: contributor

This is a better starting point: https://github.com/jgarzik/rpcsrv :)
luke-jr commented at 11:23 AM on January 1, 2015: member

Malfunctioning clients? There's nothing wrong with clients keeping a connection open to keep-alive HTTP servers...
kanzure commented at 3:32 PM on September 4, 2015: contributor

Could be closed now that #5677 is merged? see #5677 (comment) @jonasschnelli @laanwj
paveljanik commented at 7:47 PM on October 1, 2015: contributor

ping :-)
jonasschnelli commented at 7:47 PM on October 1, 2015: contributor

Solved with #5677, closing.
jonasschnelli closed this on Oct 1, 2015
DrahtBot locked this on Sep 8, 2021

Contributors