bitcoin-tx: Fix JSON validation of prevtxs #5528

pull ers35 wants to merge 3 commits into bitcoin:master from ers35:bitcoin-tx-copy-paste changing 4 files +16 −4

ers35 commented at 2:06 AM on December 23, 2014: contributor

No description provided.
bitcoin-tx: Fix JSON validation of prevtxs 2a3d988b80
bitcoin-tx: Refer to the JSON fields rather than the whole object a089c50981

ers35 commented at 3:09 AM on December 23, 2014: contributor

I had not actually tested bitcoin-tx with 2a3d988. With a089c50 I can sign a tx like so (already compromised private key):

bitcoin-tx -create -json \
'set=privatekeys:["5HpHagT65TZzG1PH3CSu63k8DbpvD8s5ip4nEB3kEsreAnchuDf"]' \
'set=prevtxs:[{"txid":"4d49a71ec9da436f71ec4ee231d04f292a29cd316f598bb7068feccabdc59485","vout":0,"scriptPubKey":"4d49a71ec9da436f71ec4ee231d04f292a29cd316f598bb7068feccabdc59485"}]' \
'sign=' \
'outaddr=0.00000001:193P6LtvS4nCnkDvM9uXn1gsSRqh4aDAz7'

{
    "txid": "184c7a9d2115ccc2f2ab9f112b6cc430d6fa9ba2dd05e96e21bd063ca1b05c61",
    "version": 1,
    "locktime": 0,
    "vin": [
    ],
    "vout": [
        {
            "value": 0.00000001,
            "n": 0,
            "scriptPubKey": {
                "asm": "OP_DUP OP_HASH160 5834479edbbe0539b31ffd3a8f8ebadc2165ed01 OP_EQUALVERIFY OP_CHECKSIG",
                "hex": "76a9145834479edbbe0539b31ffd3a8f8ebadc2165ed0188ac",
                "reqSigs": 1,
                "type": "pubkeyhash",
                "addresses": [
                    "193P6LtvS4nCnkDvM9uXn1gsSRqh4aDAz7"
                ]
            }
        }
    ],
    "hex": "01000000000101000000000000001976a9145834479edbbe0539b31ffd3a8f8ebadc2165ed0188ac00000000"
}

jonasschnelli commented at 8:06 AM on December 23, 2014: contributor

ACK
jgarzik commented at 1:59 PM on December 23, 2014: contributor

ACK
bitcoin-tx: Add test case for signing a tx 2c14d1532f
jgarzik merged this on Dec 31, 2014
jgarzik closed this on Dec 31, 2014
jgarzik referenced this in commit 39d6b5fd42 on Dec 31, 2014
jgarzik commented at 2:00 PM on December 31, 2014: contributor

tested re-ACK
jgarzik added this to the milestone 0.10.0 on Jan 6, 2015
laanwj referenced this in commit 06fdf326d3 on Jan 6, 2015
reddink referenced this in commit 283ce9f031 on May 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

ers35

jonasschnelli

jgarzik

Milestone
0.10.0